Skip failed balance reload #5550
Open
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskloetd
reviewed
Sep 30, 2024
|
|
||
| onMount(() => { | ||
| loadCkBTCTokens(); | ||
| }); | ||
|
|
||
| let loadSnsAccountsBalancesRequested = false; | ||
| let loadCkBTCAccountsBalancesRequested = false; | ||
| let loadedIcrcAccountsBalancesRequested = new Set<CanisterIdString>(); |
There was a problem hiding this comment.
This is reset when you navigate to another page, right?
Do we reload the balances every time you navigate?
| return; | ||
| } | ||
| newIds.forEach((id) => loadedIcrcAccountsBalancesRequested.add(id)); | ||
| await loadAccountsBalances(newIds); | ||
| }; | ||
|
|
There was a problem hiding this comment.
GitHub won't allow me to comment below, but on line 141:
$: (async () => {
if ($authSignedInStore) {
await Promise.allSettled([
loadSnsAccountsBalances($snsProjectsCommittedStore),
loadCkBTCAccountsBalances($ckBTCUniversesStore),
loadIcrcTokenAccounts($icrcCanistersStore),
]);
}
})();
this will execute when any of the stores change.
But we don't want to reload store B because store A changed, right?
Shouldn't this be 3 separate blocks?
| it("should not reload balances after an imported token becomes failed", async () => { | ||
| const po = await renderPage(); | ||
| const rows = await po.getTokensPagePo().getTokensTable().getRows(); | ||
| const notFailedTokenCount = ( |
There was a problem hiding this comment.
We number what this number is, right? It's always the same.
Can we expect it so it's not accidentally 0 or something?
| notFailedTokenCount | ||
| ); | ||
|
|
||
| failedImportedTokenLedgerIdsStore.add(importedToken2Id.toText()); |
There was a problem hiding this comment.
Can we check that importedToken2Id is not already in failedImportedTokenLedgerIdsStore so we know the test actually tests something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, on the tokens page, there is a flag-based mechanism to prevent reloading of token data (here and here). This is applied to the Sns and ckBTC tokens but not to the ICRC tokens, as the ICRC token list was previously static. Now, when the dapp fails to load a token, the failed token is removed from the ICRC token list, which triggers a reload of all ICRC token data. To prevent this, we apply the same flag mechanism to avoid unnecessary reloading.
Changes
Tests
Todos
Not necessary.