Use %s instead of %I to allow schema-qualified table names

df7cb · Apr 2, 2020 · af112f0 · af112f0
1 parent ff48388
commit af112f0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/contrib/bad_tuples.sql b/contrib/bad_tuples.sql
@@ -17,7 +17,7 @@ begin
 
       for ctid in select t_ctid from heap_page_items(get_raw_page(relname::text, page)) loop
         begin
-          execute format('SELECT length(t::text) FROM %I t WHERE ctid=%L', relname, ctid);
+          execute format('SELECT length(t::text) FROM %s t WHERE ctid=%L', relname, ctid);
         exception -- bad tuple
           when others then
             bad_tuples.page := page;

diff --git a/contrib/read_table.sql b/contrib/read_table.sql
@@ -17,7 +17,7 @@ begin
 
       for ctid in select t_ctid from heap_page_items(get_raw_page(relname::text, page)) loop
         begin
-          execute format('SELECT * FROM %I WHERE ctid=%L', relname, ctid) into r;
+          execute format('SELECT * FROM %s WHERE ctid=%L', relname, ctid) into r;
           if r is not null then
             return next r;
           end if;

diff --git a/contrib/rescue_table.sql b/contrib/rescue_table.sql
@@ -16,7 +16,7 @@ begin
     savename := relname || '_rescue';
   end if;
   if rescue_table.create then
-    execute format('CREATE TABLE %I (LIKE %I)', savename, relname);
+    execute format('CREATE TABLE %s (LIKE %s)', savename, relname);
   end if;
 
   select pg_relation_size(relname) / current_setting('block_size')::int into pages;
@@ -30,7 +30,7 @@ begin
 
       for ctid in select t_ctid from heap_page_items(get_raw_page(relname::text, page)) loop
         begin
-          execute format('INSERT INTO %I SELECT * FROM %I WHERE ctid=%L', savename, relname, ctid);
+          execute format('INSERT INTO %s SELECT * FROM %s WHERE ctid=%L', savename, relname, ctid);
           get diagnostics row_count = ROW_COUNT;
           good_tuples := good_tuples + row_count;
         exception -- bad tuple
@@ -52,7 +52,7 @@ begin
 
   end loop;
 
-  error := format('rescue_table %I into %I: %s of %s pages are bad, %s bad tuples, %s tuples copied',
+  error := format('rescue_table %s into %s: %s of %s pages are bad, %s bad tuples, %s tuples copied',
     relname, savename, bad_pages, pages, bad_tuples, good_tuples);
   raise log '%', error;
   return error;