fix(build): ensure a non-zero exit code on failure (vitejs#1038)

Previously, when the following actions failed, the process would exit with an exit code of zero, which would break CI. - transform with Esbuild - transform CSS - minify CSS - load PostCSS config
devqin · Dec 4, 2020 · 650ca16 · 650ca16
1 parent fe937c4
commit 650ca16
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 5 deletions.
diff --git a/src/node/build/buildPluginCss.ts b/src/node/build/buildPluginCss.ts
@@ -85,6 +85,7 @@ export const createBuildCssPlugin = ({
           if (result.errors.length) {
             console.error(`[vite] error applying css transforms: `)
             result.errors.forEach(console.error)
+            process.exit(1)
           }
           css = result.code
           modules = result.modules
@@ -228,6 +229,7 @@ function minifyCSS(css: string) {
   if (res.errors && res.errors.length) {
     console.error(chalk.red(`[vite] error when minifying css:`))
     console.error(res.errors)
+    process.exit(1)
   }
 
   if (res.warnings && res.warnings.length) {

diff --git a/src/node/build/buildPluginEsbuild.ts b/src/node/build/buildPluginEsbuild.ts
@@ -39,7 +39,8 @@ export const createEsbuildPlugin = async (
             ...jsxConfig,
             ...(isVueTs ? { loader: 'ts' } : null)
           },
-          jsx
+          jsx,
+          true // exitOnFailure
         )
       }
     }

diff --git a/src/node/esbuildService.ts b/src/node/esbuildService.ts
@@ -67,7 +67,8 @@ export const transform = async (
   src: string,
   request: string,
   options: TransformOptions = {},
-  jsxOption?: SharedConfig['jsx']
+  jsxOption?: SharedConfig['jsx'],
+  exitOnFailure?: boolean
 ) => {
   const service = await ensureService()
   const file = cleanUrl(request)
@@ -114,6 +115,9 @@ export const transform = async (
       console.error(e)
     }
     debug(`options used: `, options)
+    if (exitOnFailure) {
+      process.exit(1)
+    }
     return {
       code: '',
       map: undefined

diff --git a/src/node/utils/cssUtils.ts b/src/node/utils/cssUtils.ts
@@ -68,7 +68,7 @@ export async function compileCss(
   isBuild: boolean = false
 ): Promise<SFCStyleCompileResults | string> {
   const id = hash_sum(publicPath)
-  const postcssConfig = await loadPostcssConfig(root)
+  const postcssConfig = await loadPostcssConfig(root, isBuild)
   const { compileStyleAsync } = resolveCompiler(root)
 
   if (
@@ -138,7 +138,8 @@ type PostCSSConfigResult = ReturnType<typeof postcssrc> extends Promise<infer T>
 let cachedPostcssConfig: PostCSSConfigResult | null | undefined
 
 async function loadPostcssConfig(
-  root: string
+  root: string,
+  exitOnFailure?: boolean
 ): Promise<PostCSSConfigResult | null> {
   if (cachedPostcssConfig !== undefined) {
     return cachedPostcssConfig
@@ -150,13 +151,16 @@ async function loadPostcssConfig(
     if (!/No PostCSS Config found/.test(e.message)) {
       console.error(chalk.red(`[vite] Error loading postcss config:`))
       console.error(e)
+      if (exitOnFailure) {
+        process.exit(1)
+      }
     }
     return (cachedPostcssConfig = null)
   }
 }
 
 export async function resolvePostcssOptions(root: string, isBuild: boolean) {
-  const config = await loadPostcssConfig(root)
+  const config = await loadPostcssConfig(root, isBuild)
   const options = config && config.options
   const plugins = config && config.plugins ? config.plugins.slice() : []
   plugins.unshift(require('postcss-import')())
-Original file line number
+Diff line change
@@ Expand Up / @@ -39,7 +39,8 @@ export const createEsbuildPlugin = async ( @@
                 ...jsxConfig,
                 ...(isVueTs ? { loader: 'ts' } : null)
               },
-              jsx
+              jsx,
+              true // exitOnFailure
             )
           }
         }
@@ Expand Down @@