-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create PR interstitial dialog refinements #2280
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
69d78c5
Remove redundant jsdoc type annotations
niik ec812a1
Convert private variable into getter and get rid of constructor
niik 88d14d9
Add a loading state for the pushbranchcommits dialog
niik 2b71ce8
Extract, document and simplify pluralization method
niik 6e1bf09
Simplify: Include the number of commits in the pluralize method
niik 461a05e
Add a type guard to bring back some of the old behavior
niik ae7ff12
:book:
niik 327276f
Whoops
niik a413554
:art: cleanup
niik 2412ba1
Break it up a little
niik 88641ed
:art: cleanup
niik bc4e924
:art: naming
niik b520ddf
Add a generic Ref component
niik acea310
Render branch names as Ref components
niik 4d9ac25
Fix unnecessarily nested paths
niik 0390fa4
Try a new take on the push view
niik a56dbe9
Same logic for publish, ask a question
niik 7d446a2
Ask some question in the title
niik bf255b1
language
niik 1bff48f
Empty test commit
niik 692c992
Fix pluralization of local commits
niik 856b72d
Remove obsolete doc
niik 6a23399
:art:
niik 428b8fb
Follow the component class naming conventions
niik 7baa69a
Add some more words to the buttons
niik 4bbbc32
Merge branch 'master' into create-pr-dialog-refinements
niik 64541a5
Revert to action texts
niik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add a generic Ref component
- Loading branch information
commit b520ddf991bba5639ac0366a8406ee983706c4e1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import * as React from 'react' | ||
|
||
/** | ||
* A simple style component used to mark up arbitrary references such as | ||
* branches, commit shas, paths or other content which needs to be presented | ||
* in an emphasized way and that benefit from fixed-width fonts. | ||
* | ||
* While the styling of the component _may_ differs depending on what context | ||
* it appears in the general style is an inline-box with a suitable background | ||
* color, using a fixed-width font. | ||
*/ | ||
export class Ref extends React.Component<{}, {}> { | ||
This comment was marked as spam.
Sorry, something went wrong. |
||
public render() { | ||
return ( | ||
<em className="ref"> | ||
{this.props.children} | ||
</em> | ||
) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
em.ref { | ||
This comment was marked as spam.
Sorry, something went wrong. |
||
font-style: normal; | ||
font-family: var(--font-family-monospace); | ||
background: var(--path-segment-background); | ||
border: var(--path-segment-background); | ||
border-radius: var(--border-radius); | ||
padding: var(--path-segment-padding); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.