Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PR interstitial dialog refinements #2280

Merged
merged 27 commits into from
Jul 26, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
69d78c5
Remove redundant jsdoc type annotations
niik Jul 19, 2017
ec812a1
Convert private variable into getter and get rid of constructor
niik Jul 19, 2017
88d14d9
Add a loading state for the pushbranchcommits dialog
niik Jul 19, 2017
2b71ce8
Extract, document and simplify pluralization method
niik Jul 19, 2017
6e1bf09
Simplify: Include the number of commits in the pluralize method
niik Jul 19, 2017
461a05e
Add a type guard to bring back some of the old behavior
niik Jul 19, 2017
ae7ff12
:book:
niik Jul 19, 2017
327276f
Whoops
niik Jul 19, 2017
a413554
:art: cleanup
niik Jul 19, 2017
2412ba1
Break it up a little
niik Jul 19, 2017
88641ed
:art: cleanup
niik Jul 19, 2017
bc4e924
:art: naming
niik Jul 19, 2017
b520ddf
Add a generic Ref component
niik Jul 19, 2017
acea310
Render branch names as Ref components
niik Jul 19, 2017
4d9ac25
Fix unnecessarily nested paths
niik Jul 19, 2017
0390fa4
Try a new take on the push view
niik Jul 19, 2017
a56dbe9
Same logic for publish, ask a question
niik Jul 19, 2017
7d446a2
Ask some question in the title
niik Jul 19, 2017
bf255b1
language
niik Jul 19, 2017
1bff48f
Empty test commit
niik Jul 19, 2017
692c992
Fix pluralization of local commits
niik Jul 19, 2017
856b72d
Remove obsolete doc
niik Jul 21, 2017
6a23399
:art:
niik Jul 21, 2017
428b8fb
Follow the component class naming conventions
niik Jul 21, 2017
7baa69a
Add some more words to the buttons
niik Jul 21, 2017
4bbbc32
Merge branch 'master' into create-pr-dialog-refinements
niik Jul 26, 2017
64541a5
Revert to action texts
niik Jul 26, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a generic Ref component
  • Loading branch information
niik committed Jul 19, 2017
commit b520ddf991bba5639ac0366a8406ee983706c4e1
20 changes: 20 additions & 0 deletions app/src/ui/lib/ref.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import * as React from 'react'

/**
* A simple style component used to mark up arbitrary references such as
* branches, commit shas, paths or other content which needs to be presented

This comment was marked as spam.

* in an emphasized way and that benefit from fixed-width fonts.
*
* While the styling of the component _may_ differs depending on what context
* it appears in the general style is an inline-box with a suitable background
* color, using a fixed-width font.
*/
export class Ref extends React.Component<{}, {}> {

This comment was marked as spam.

public render() {
return (
<em className="ref">
{this.props.children}
</em>
)
}
}
1 change: 1 addition & 0 deletions app/styles/_ui.scss
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,4 @@
@import "ui/vertical-segmented-control";
@import "ui/blank-slate";
@import "ui/terms-and-conditions";
@import "ui/ref";
8 changes: 8 additions & 0 deletions app/styles/ui/_ref.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
em.ref {

This comment was marked as spam.

font-style: normal;
font-family: var(--font-family-monospace);
background: var(--path-segment-background);
border: var(--path-segment-background);
border-radius: var(--border-radius);
padding: var(--path-segment-padding);
}