-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Cyrillic layout issue #6890
base: master
Are you sure you want to change the base?
Conversation
Здравствуйте @bellerofonte ! First let me say thank you for actively sharing your take on Synergy, this encourages us a great deal. Finally, even though we will surely take into account this approach, I guess you understand it and it may not even need said but the PR cannot be merged as is, and would need a lot of work to get to a point where it can reach our vast user base (re-mapping would need to be an opt-in or auto-assessed element, it would need to cope not only with other languages but even within Russian, it would require the standard, the PC, and the АБВ layouts). Please remain in contact, and do consider we are hiring. |
Hi @ignacionr! Thank you for your response.
Sure, I just wanted you to note this approach. I'm closing this PR, but I will continue to improve this branch for my personal environment. You are welcome to use my work as soon as you need it. |
Hi @bellerofonte, just noticed this PR was closed without the work being used. I'm reopening this in the hope that we can perhaps use your contribution. |
c9edbe0
to
181c34e
Compare
b909597
to
c22b985
Compare
93c10b5
to
fa9b2d9
Compare
This should be rechecked to see if its still a vaild issue now that we should have proper utf16 pairs. |
this PR is for #6862
I've investigated the issue and came to following results (macOS runs Synergy server, Linux runs synergy client):
So I decide to remap every incoming
KeyID
on client side using hardcoded table. I.e. I tried to translate any incomingCyrillic unicode key id
intoBasic Latin unicode key id
using may Macbook's [physical] keyboard layout.This still works not ideal, but much more comfortable to use.