Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Cyrillic layout issue #6890

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bellerofonte
Copy link

this PR is for #6862

I've investigated the issue and came to following results (macOS runs Synergy server, Linux runs synergy client):

  1. If macOS's keyboard layout is EN(US), any layout on Linux works pretty well
  2. If macOS's keyboard layout is RU(RU) and Linux hasn't RU layout added - nothing gets typed
  3. If macOS's keyboard layout is RU(RU) and Linux hasn't RU layout added - Cyrillic characters get always typed whatever layout is chosen on Linux.

So I decide to remap every incoming KeyID on client side using hardcoded table. I.e. I tried to translate any incoming Cyrillic unicode key id into Basic Latin unicode key id using may Macbook's [physical] keyboard layout.
This still works not ideal, but much more comfortable to use.

@ignacionr
Copy link
Contributor

Здравствуйте @bellerofonte !

First let me say thank you for actively sharing your take on Synergy, this encourages us a great deal.
Secondly, let me empathise with you as a daily user of both EN and RU mappings.

Finally, even though we will surely take into account this approach, I guess you understand it and it may not even need said but the PR cannot be merged as is, and would need a lot of work to get to a point where it can reach our vast user base (re-mapping would need to be an opt-in or auto-assessed element, it would need to cope not only with other languages but even within Russian, it would require the standard, the PC, and the АБВ layouts).

Please remain in contact, and do consider we are hiring.

@bellerofonte
Copy link
Author

bellerofonte commented Dec 29, 2020

Hi @ignacionr!

Thank you for your response.

I guess you understand it and it may not even need said but the PR cannot be merged as is

Sure, I just wanted you to note this approach. I'm closing this PR, but I will continue to improve this branch for my personal environment. You are welcome to use my work as soon as you need it.

@nbolton
Copy link
Member

nbolton commented Sep 12, 2024

Hi @bellerofonte, just noticed this PR was closed without the work being used. I'm reopening this in the hope that we can perhaps use your contribution.

@nbolton nbolton reopened this Sep 12, 2024
@nbolton nbolton marked this pull request as draft September 12, 2024 10:04
@nbolton nbolton changed the title - fixed cyrillic layout issue Fixed cyrillic layout issue Oct 11, 2024
@nbolton nbolton changed the title Fixed cyrillic layout issue Fixed Cyrillic layout issue Oct 11, 2024
@sithlord48 sithlord48 force-pushed the master branch 4 times, most recently from c9edbe0 to 181c34e Compare October 13, 2024 21:51
@sithlord48 sithlord48 force-pushed the master branch 14 times, most recently from b909597 to c22b985 Compare November 6, 2024 20:10
@sithlord48 sithlord48 force-pushed the master branch 4 times, most recently from 93c10b5 to fa9b2d9 Compare November 6, 2024 20:41
@sithlord48
Copy link
Collaborator

This should be rechecked to see if its still a vaild issue now that we should have proper utf16 pairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants