fix: add liveness probe for metadata-envoy-deployment #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
3 tasks
|
@thesuperzapper what version of envoy is being used here? The referenced livenessProbe in canonical/envoy-operator#124 works for 1.12 IIRC (aka pipelines 2.0). When we bumped envoy to 1.27 (pipelines 2.2.0), we hit the issue described in canonical/envoy-operator#106 where returns a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #187
This PR adds a liveness probe to the
Deployment/metadata-envoy-deploymentPods. It seems like sometimes this deployment can be running but not functional, resulting inCannot get MLMD objects from Metadata storeerrors when running V2 Kubeflow Pipelines:This was uncovered in canonical/bundle-kubeflow#966 (comment).