Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to overwrite Docker read and open timeout values #10359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Aug 4, 2024

What are you trying to accomplish?

Allows overwriting the read and open timeout values for interactions with the docker registry using two separate environment variables

What issues does this affect or fix?

I do not have any issue in the tracker, but I noticed this need while using dependabot-core with slow private registries

If there were multiple ways to approach the problem, why did you pick this one?

Initially, I considered using the existing environment variables defined here :

DEFAULT_OPEN_TIMEOUT_IN_SECONDS = 2
DEFAULT_READ_TIMEOUT_IN_SECONDS = 5

But I noticed that the default values there are different and I figured that separate environment properties may be better

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@github-actions github-actions bot added the L: docker Docker containers label Aug 4, 2024
@yeikel yeikel force-pushed the timeout/envs branch 3 times, most recently from 9035f98 to 2cbcb34 Compare August 4, 2024 05:32
@yeikel yeikel marked this pull request as ready for review August 4, 2024 05:40
@yeikel yeikel requested a review from a team as a code owner August 4, 2024 05:40
@yeikel
Copy link
Contributor Author

yeikel commented Aug 4, 2024

The e2e failures seem unrelated to my change

@yeikel yeikel force-pushed the timeout/envs branch 2 times, most recently from 6c031da to 8209f5d Compare August 11, 2024 23:37
@yeikel
Copy link
Contributor Author

yeikel commented Dec 4, 2024

@jeffwidman Any chance you can review this?

@yeikel yeikel force-pushed the timeout/envs branch 2 times, most recently from 641038e to 6e51aee Compare December 13, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: docker Docker containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant