feat: add option to overwrite Docker read and open timeout values #10359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Allows overwriting the read and open timeout values for interactions with the docker registry using two separate environment variables
What issues does this affect or fix?
I do not have any issue in the tracker, but I noticed this need while using
dependabot-core
with slow private registriesIf there were multiple ways to approach the problem, why did you pick this one?
Initially, I considered using the existing environment variables defined here :
dependabot-core/common/lib/dependabot/clients/github_with_retries.rb
Lines 13 to 14 in c95a0fc
But I noticed that the default values there are different and I figured that separate environment properties may be better
Checklist