Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

v1.3.0 breaks URL signing Β #9

Open
@tnolet

Description

Hi,

not complaining, but the v1.3.0 break backwards compatibility. My apps AWS IOT function that uses this package broke. Rolling back to version 1.1.0 fixed everything. My mistake to not pin the version, but still.
I don't really know why it broke, but I use your package in the following way:

const v4 = require('aws-signature-v4')
const crypto = require('crypto')

function getSignedUrl () {
  return v4.createPresignedURL(
      'GET',
      config.aws.iotEndpointHost.toLowerCase(),
      '/mqtt',
      'iotdevicegateway',
      crypto.createHash('sha256').update('', 'utf8').digest('hex'),
    {
      'key': config.aws.iotAccessKey,
      'secret': config.aws.iotSecretKey,
      'protocol': 'wss',
      'region': config.aws.iotAwsRegion
    }
    )
}

So I guess something changed in the createPresignedURL method

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions