Revert "core: don't include_str extension js code (#10786)" #14614
Conversation
This reverts commit 10e50a1
AaronO
requested review from
crowlKats,
lucacasonato,
bartlomieju and
littledivy
as code owners
There was a problem hiding this comment.
webgpu/src changes seems unrelated. https://github.com/denoland/deno/pull/14614/files#diff-924b4b7acc08e4f385a8158fcef447fc3006dd533da7a6dc6b2039d3ab818e28
It's not, we either need to move the files (as I did) or change the include path to add So yeah, we'll have to patch/change that upstream |
|
This PR closes #11030. |
…enoland#14614) This reverts commit 10e50a1 Alternative to denoland#13217, IMO the tradeoffs made by denoland#10786 aren't worth it. It breaks abstractions (crates being self-contained, deno_core without snapshotting etc...) and causes pain points / gotchas for both embedders & devs for a relatively minimal gain in incremental build time ... Closes denoland#11030
This reverts commit 10e50a1
Alternative to #13217, IMO the tradeoffs made by #10786 aren't worth it.
It breaks abstractions (crates being self-contained, deno_core without snapshotting etc...) and causes pain points / gotchas for both embedders & devs for a relatively minimal gain in incremental build time ...
Closes #11030