Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix notebook link in docs #315

Merged
merged 1 commit into from
Nov 28, 2023
Merged

docs: fix notebook link in docs #315

merged 1 commit into from
Nov 28, 2023

Conversation

laurenzse
Copy link
Contributor

@laurenzse laurenzse commented Nov 23, 2023

The links in the documentation to the original notebooks are currently broken. This PR introduces the missing / to the links:

Original link:

https://github.com/deepcharles/rupturesblob/master/docs/examples/music-segmentation.ipynb

New link:

https://github.com/deepcharles/ruptures/blob/master/docs/examples/music-segmentation.ipynb

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03ff932) 98.77% compared to head (0f1fadf) 98.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          40       40           
  Lines         978      978           
=======================================
  Hits          966      966           
  Misses         12       12           
Flag Coverage Δ
unittests 98.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oboulant oboulant changed the title Fix broken notebook link in docs docs: fix notebook link in docs Nov 28, 2023
@oboulant oboulant added Type: Fix Bug or Bug fixes Type: Documentation Documentation only changes labels Nov 28, 2023
Copy link
Collaborator

@oboulant oboulant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oboulant
Copy link
Collaborator

Thanks !
I will regenerate the docs once this is merged !

@oboulant oboulant merged commit f9952f7 into deepcharles:master Nov 28, 2023
21 checks passed
@oboulant
Copy link
Collaborator

Docs regenerated and online !
GHA run : https://github.com/deepcharles/ruptures/actions/runs/7024108194
ruptures docs, still here : https://centre-borelli.github.io/ruptures-docs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Documentation only changes Type: Fix Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants