feat(vmclass): add events about available nodes and sizing policies changed #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eofff
force-pushed
the
feat/vmclass/add-events-about-node-and-policy-changes
branch
from
40ac6c9 to
7dd0311
Compare
eofff
changed the title
eofff
force-pushed
the
feat/vmclass/add-events-about-node-and-policy-changes
branch
from
7dd0311 to
2599df7
Compare
Isteb4k
requested changes
Dec 25, 2024
images/virtualization-artifact/pkg/controller/vmclass/internal/discovery.go
Outdated
Show resolved
Hide resolved
eofff
force-pushed
the
feat/vmclass/add-events-about-node-and-policy-changes
branch
3 times, most recently
from
57f3f1a to
ea2db1c
Compare
eofff
force-pushed
the
feat/vmclass/add-events-about-node-and-policy-changes
branch
from
9d7eafe to
1afff48
Compare
added 3 commits
January 15, 2025 11:51
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
eofff
force-pushed
the
feat/vmclass/add-events-about-node-and-policy-changes
branch
from
1afff48 to
bdc28ef
Compare
diafour
reviewed
Jan 15, 2025
Comment on lines
+81
to
+84
| cb. | ||
| Status(metav1.ConditionFalse). | ||
| Reason(vmclasscondition.ReasonVMClassFree). | ||
| Message("") |
There was a problem hiding this comment.
No need to add a separate condition "VMClassFree", vmclass is in a deletion state at this point, it will be deleted almost immediately after removing finalizers.
Isteb4k
requested changes
Jan 22, 2025
| @@ -95,4 +92,13 @@ const ( | |||
|
|
|||
| // ReasonDataSourceDiskProvisioningFailed is event reason that DataSource disk provisioning is failed. | |||
| ReasonDataSourceDiskProvisioningFailed = "DataSourceImportDiskProvisioningFailed" | |||
|
|
|||
| // ReasonVMClassSizingPoliciesWasChanged is event reason that VMClass sizing policies was changed. | |||
|
|
||
| func (v *PolicyChangesValidator) ValidateUpdate(_ context.Context, oldVMClass, newVMClass *v1alpha2.VirtualMachineClass) (admission.Warnings, error) { | ||
| if !reflect.DeepEqual(oldVMClass.Spec.SizingPolicies, newVMClass.Spec.SizingPolicies) { | ||
| v.recorder.Event(newVMClass, corev1.EventTypeNormal, v1alpha2.ReasonVMClassSizingPoliciesWasChanged, "Sizing policies was changed") |
| cb. | ||
| Status(metav1.ConditionTrue). | ||
| Reason(vmclasscondition.ReasonVMClassInUse). | ||
| Message(msg) | ||
| return reconcile.Result{RequeueAfter: 60 * time.Second}, nil |
There was a problem hiding this comment.
Why not subscribe to virtual machine deletion?
Comment on lines
+81
to
+84
| cb. | ||
| Status(metav1.ConditionFalse). | ||
| Reason(vmclasscondition.ReasonVMClassFree). | ||
| Message("") |
| prevMap := make(map[string]struct{}) | ||
| currentMap := make(map[string]struct{}) | ||
|
|
||
| for _, n := range prev { |
There was a problem hiding this comment.
n usually means a number, but I suppose not in this context.
| removed []string | ||
| } | ||
|
|
||
| var _ = Describe("DiscoveryHandler Run", func() { |
There was a problem hiding this comment.
DiscoveryHandler doesn't have method Run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using new events api.
Add event when list of available nodes changed.
Add event when sizing policies changed.
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist