Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move secrets to ENV #13268

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from
Open

Move secrets to ENV #13268

wants to merge 37 commits into from

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Jul 31, 2024 •
edited
Loading

🎩 What? Why?

This PR is removing all the Rails.application.secrets, as this is being deprecated in the upcoming rails 7.1 version, and is going to be removed in rails 7.2.

📌 Related Issues

Link your PR to an issue

Testing

  1. All the pipeline should be green
  2. Using this branch, create a new development application
  3. Boot the application
  4. See everything works as intended.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu added the type: change PRs that implement a change for an existing feature label Jul 31, 2024
@alecslupu alecslupu mentioned this pull request Jul 31, 2024
Draft
github-actions[bot]
github-actions bot previously approved these changes Jul 31, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Jul 31, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Jul 31, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Aug 1, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Aug 1, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Aug 1, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Aug 2, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Oct 19, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Oct 19, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Nov 4, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Nov 4, 2024
View reviewed changes
@andreslucena andreslucena removed this from the 0.30.0 milestone Nov 18, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 9, 2024
View reviewed changes
@github-actions github-actions bot added module: proposals module: meetings module: initiatives type: internal PRs that aren't necessary to add to the CHANGELOG for implementers and removed configuration labels Dec 9, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 9, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@andreslucena andreslucena Awaiting requested review from andreslucena

At least 2 approving reviews are required to merge this pull request.

Assignees

@andreslucena andreslucena

Labels
module: accountability module: api module: budgets module: core module: generators module: initiatives module: meetings module: proposals module: system module: verifications team: documentation type: change PRs that implement a change for an existing feature type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
Maintainers' backlog
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecslupu @andreslucena