Skip to content

Commit

Permalink
Settings editor - add "..." in a fixed position to indicate that a de…
Browse files Browse the repository at this point in the history
…scription is expandable
  • Loading branch information
roblourens committed May 21, 2018
1 parent a5bfda7 commit cdea1bd
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,16 @@
cursor: pointer;
}

.settings-editor > .settings-body > .settings-list-container .monaco-list-row.is-expandable:not(.is-expanded) .setting-item-description::after {
content: '…';
display: block;
height: 4px;
width: 8px;
position: absolute;
bottom: 16px;
left: 580px;
}

.settings-editor > .settings-body > .settings-list-container .monaco-list-row .setting-item-value {
display: flex;
}
Expand Down
3 changes: 3 additions & 0 deletions src/vs/workbench/parts/preferences/browser/settingsEditor2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,7 @@ interface ISettingItemTemplate extends IDisposableTemplate {
categoryElement: HTMLElement;
labelElement: HTMLElement;
descriptionElement: HTMLElement;
showMoreElement: HTMLElement;
valueElement: HTMLElement;
overridesElement: HTMLElement;
}
Expand Down Expand Up @@ -811,6 +812,7 @@ class SettingItemRenderer implements IRenderer<ISettingItemEntry, ISettingItemTe
const labelElement = DOM.append(titleElement, $('span.setting-item-label'));
const overridesElement = DOM.append(titleElement, $('span.setting-item-overrides'));
const descriptionElement = DOM.append(leftElement, $('.setting-item-description'));
const showMoreElement = DOM.append(leftElement, $('.setting-show-more'));

const valueElement = DOM.append(rightElement, $('.setting-item-value'));

Expand All @@ -823,6 +825,7 @@ class SettingItemRenderer implements IRenderer<ISettingItemEntry, ISettingItemTe
categoryElement,
labelElement,
descriptionElement,
showMoreElement,
valueElement,
overridesElement
};
Expand Down

0 comments on commit cdea1bd

Please sign in to comment.