Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9466. Check commit for diff from that PR.
Full video demo: https://streamable.com/zva2i4
After some feedback on 18.9 RC, and given how confusing and polarizing the feature is, i think it is now pretty important to add a visible toggle and a permanent setting (
cl_spec_auto_sync
, please check the description on whether it is clear enough)Adds a in-game menu button for toggling this feature (it toggles both ingame state and the config, only shown in spectator mode)
Along with these status tooltips:
Active
Inactive
Disabled
Enabled
(when it is not possible to activate)Unavailable for this player
(when spectating older clients))This is quite a few localization strings but I think it is worth it for clarity.
This button toggles between three or two states depends on the context. Either
Active
-Inactive
-Disabled
or justEnabled
-Disabled
.When the feature is not disabled, assume player do not mind the feature and currently taking Skeith suggestion to automatically activate when player resets zoom, and deactivate after zoom+ or zoom-. I did not check whether current zoom is default because:
Also updated the indicator icon's color to match the button and make it less distracting. And it will completely hide if player disabled the feature.
I'd like this to be in 18.9, even though this is a pretty big change, but it came from discord feedback. Review carefully.
Demo menu is unchanged because I think it doesn't make sense to follow the config.
Checklist