Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mistaken dev-requirements change #945

Merged
merged 12 commits into from
Sep 28, 2023
Merged

fix mistaken dev-requirements change #945

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8577fa5
add dbt show tests
MichelleArk Sep 18, 2023
7bfe1f2
changelog entry
MichelleArk Sep 25, 2023
093c97e
Merge branch 'main' into test-limit-in-show-sql
MichelleArk Sep 25, 2023
2de4a60
Merge branch 'main' into test-limit-in-show-sql
McKnight-42 Sep 28, 2023
6b180bf
repoint to core main
McKnight-42 Sep 28, 2023
e27c4e1
reuse core fixture for dbt show sql header test
MichelleArk Sep 28, 2023
3268ec6
fix dev-requirements.txt
colin-rogers-dbt Sep 28, 2023
4cfb464
use dynamic schema in test_grant_access_to.py
colin-rogers-dbt Jul 21, 2023
86fecdd
use dynamic schema in test_grant_access_to.py
colin-rogers-dbt Jul 21, 2023
21573ef
revert setup
colin-rogers-dbt Sep 22, 2023
f89b5fa
Merge branch 'main' into test-limit-in-show-sql
colin-rogers-dbt Sep 28, 2023
f80be08
fix dev-requirements.txt
colin-rogers-dbt Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reuse core fixture for dbt show sql header test
  • Loading branch information
@MichelleArk
MichelleArk committed Sep 28, 2023
commit e27c4e13cbc9e39ff4438ceaed9817426aaf5460
4 changes: 2 additions & 2 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# install latest changes in dbt-core
# TODO: how to automate switching from develop to version branches?
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter
git+https://github.com/dbt-labs/dbt-core.git@improve-show-fixture#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git@improve-show-fixture#egg=dbt-tests-adapter&subdirectory=tests/adapter

# if version 1.x or greater -> pin to major version
# if version 0.x -> pin to minor
Expand Down
22 changes: 1 addition & 21 deletions tests/functional/adapter/dbt_show/test_dbt_show.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,9 @@
import pytest
from dbt.tests.adapter.dbt_show.test_dbt_show import BaseShowSqlHeader, BaseShowLimit


my_model_sql_header_sql = """
{{
config(
materialized = "table"
)
}}

{% call set_sql_header(config) %}
DECLARE DEMO STRING DEFAULT 'hello world';
{% endcall %}

SELECT DEMO as column_name
"""


class TestBigQueryShowLimit(BaseShowLimit):
pass


class TestBigQueryShowSqlHeader(BaseShowSqlHeader):
@pytest.fixture(scope="class")
def models(self):
return {
"sql_header.sql": my_model_sql_header_sql,
}
pass