Implement initial adapter tests on bigquery (#142)

dbt-labs · Mar 29, 2022 · edebc47 · edebc47
1 parent 072050e
commit edebc47
Showing 7 changed files with 106 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## dbt-bigquery 1.1.0 (TBD)
+
+### Under the hood
+- Use dbt.tests.adapter.basic in tests (new test framework) ([#135](https://github.com/dbt-labs/dbt-bigquery/issues/135), [#142](https://github.com/dbt-labs/dbt-bigquery/pull/142))
+
 ## dbt-bigquery 1.1.0b1 (March 23, 2022)
 ### Features
 - Provide a fine-grained control of the timeout and retry of BigQuery query with four new dbt profile configs: `job_creation_timeout_seconds`, `job_execution_timeout_seconds`, `job_retry_deadline_seconds`, and `job_retries` ([#45](https://github.com/dbt-labs/dbt-bigquery/issues/45), [#50](https://github.com/dbt-labs/dbt-bigquery/pull/50))

diff --git a/dbt/adapters/bigquery/impl.py b/dbt/adapters/bigquery/impl.py
@@ -849,3 +849,18 @@ def string_add_sql(
             raise dbt.exceptions.RuntimeException(
                 f'Got an unexpected location value of "{location}"'
             )
+
+    # This is used by the test suite
+    def run_sql_for_tests(self, sql, fetch, conn=None):
+        """ For the testing framework.
+        Run an SQL query on a bigquery adapter. No cursors, transactions,
+        etc. to worry about"""
+
+        do_fetch = fetch != 'None'
+        _, res = self.execute(sql, fetch=do_fetch)
+
+        # convert dataframe to matrix-ish repr
+        if fetch == 'one':
+            return res[0]
+        else:
+            return list(res)
diff --git a/dev_requirements.txt b/dev_requirements.txt
@@ -1,6 +1,7 @@
 # install latest changes in dbt-core
 # TODO: how to automate switching from develop to version branches?
-git+https://github.com/dbt-labs/dbt.git#egg=dbt-core&subdirectory=core
+git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
+git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter
 
 bumpversion
 flake8

diff --git a/pytest.ini b/pytest.ini
@@ -0,0 +1,10 @@
+[pytest]
+filterwarnings =
+    ignore:.*'soft_unicode' has been renamed to 'soft_str'*:DeprecationWarning
+    ignore:unclosed file .*:ResourceWarning
+env_files =
+    test.env
+testpaths =
+    tests/unit
+    tests/integration
+    tests/functional
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -0,0 +1,22 @@
+import pytest
+import os
+import json
+
+# Import the fuctional fixtures as a plugin
+# Note: fixtures with session scope need to be local
+
+pytest_plugins = ["dbt.tests.fixtures.project"]
+
+# The profile dictionary, used to write out profiles.yml
+@pytest.fixture(scope="class")
+def dbt_profile_target():
+    credentials_json_str = os.getenv('BIGQUERY_TEST_SERVICE_ACCOUNT_JSON').replace("'", '')
+    credentials = json.loads(credentials_json_str)
+    project_id = credentials.get('project_id')
+    return {
+        'type': 'bigquery',
+        'method': 'service-account-json',
+        'threads': 1,
+        'project': project_id,
+        'keyfile_json': credentials,
+    }
diff --git a/tests/functional/adapter/test_basic.py b/tests/functional/adapter/test_basic.py
@@ -0,0 +1,52 @@
+import pytest
+
+from dbt.tests.adapter.basic.test_base import BaseSimpleMaterializations
+from dbt.tests.adapter.basic.test_singular_tests import BaseSingularTests
+from dbt.tests.adapter.basic.test_singular_tests_ephemeral import (
+    BaseSingularTestsEphemeral,
+)
+from dbt.tests.adapter.basic.test_empty import BaseEmpty
+from dbt.tests.adapter.basic.test_ephemeral import BaseEphemeral
+from dbt.tests.adapter.basic.test_incremental import BaseIncremental
+from dbt.tests.adapter.basic.test_generic_tests import BaseGenericTests
+from dbt.tests.adapter.basic.test_snapshot_check_cols import BaseSnapshotCheckCols
+from dbt.tests.adapter.basic.test_snapshot_timestamp import BaseSnapshotTimestamp
+
+
+class TestSimpleMaterializationsBigQuery(BaseSimpleMaterializations):
+    # This test requires a full-refresh to replace a table with a view
+    @pytest.fixture(scope="class")
+    def test_config(self):
+        return {"require_full_refresh": True}
+
+
+class TestSingularTestsBigQuery(BaseSingularTests):
+    pass
+
+
+class TestSingularTestsEphemeralBigQuery(BaseSingularTestsEphemeral):
+    pass
+
+
+class TestEmptyBigQuery(BaseEmpty):
+    pass
+
+
+class TestEphemeralBigQuery(BaseEphemeral):
+    pass
+
+
+class TestIncrementalBigQuery(BaseIncremental):
+    pass
+
+
+class TestGenericTestsBigQuery(BaseGenericTests):
+    pass
+
+
+class TestSnapshotCheckColsBigQuery(BaseSnapshotCheckCols):
+    pass
+
+
+class TestSnapshotTimestampBigQuery(BaseSnapshotTimestamp):
+    pass
diff --git a/tox.ini b/tox.ini
@@ -29,10 +29,3 @@ commands =
 deps =
   -rdev_requirements.txt
   -e.
-
-[pytest]
-env_files =
-    test.env
-testpaths =
-    tests/unit
-    tests/integration