Migration to API version v1beta2 #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanger
force-pushed
the
api-v1beta2
branch
from
3398b16 to
be62534
Compare
allanger
force-pushed
the
api-v1beta2
branch
6 times, most recently
from
295bd19 to
de29ea4
Compare
dabde
reviewed
Aug 18, 2024
| // when the Database resource is removed from Kubernetes | ||
| DeletionProtected bool `json:"deletionProtected"` | ||
| Postgres Postgres `json:"postgres,omitempty"` | ||
| // Mysql Mysql `json:"mysql,omitempty"` |
dabde
reviewed
Aug 18, 2024
| // Is db-operator able to connect to the database server | ||
| Connected bool `json:"connected"` | ||
| // A database server url that will be used for creating databases | ||
| URL string `json:"url,omitempty"` |
There was a problem hiding this comment.
what is this doing? Status and comment with creating confuse me a little.
There was a problem hiding this comment.
It's just a URL of a database, a comment is probably confusing, I will change
dabde
reviewed
Aug 18, 2024
go.mod
Outdated
| @@ -7,12 +7,12 @@ toolchain go1.22.4 | |||
| replace github.com/imdario/mergo => github.com/imdario/mergo v0.3.16 | |||
|
|
|||
| require ( | |||
| bou.ke/monkey v1.0.2 | |||
| bou.ke/monkey v1.0.2 // indirect | |||
There was a problem hiding this comment.
go mod tidy? could not found any monkey patching in this branch.
| log.Error(err, "can't get port information from the instanceRef") | ||
| return nil, nil, err | ||
| } | ||
| func FetchDbInstanceData(ctx context.Context) { |
There was a problem hiding this comment.
to keep the interface, or a todo missing?
There was a problem hiding this comment.
I wanted to separate the database helper code into database and instance too, but then I thought that it should be another PR.
I will remove that function
allanger
force-pushed
the
api-v1beta2
branch
from
f25bb70 to
ed07c0f
Compare
allanger
force-pushed
the
api-v1beta2
branch
2 times, most recently
from
0a07a06 to
96b5ca4
Compare
TemplatedSecrets are replaced with credentials.secrets, so they should be gone
Google instance are removed as well as a lot of different things that I would like to move to Databases or other resources.
Some minor refactoring mostly, also `go mod tidy` and linters
Since none of devs seem to use Lima, the config is not maintained
allanger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, it's a pretty big PR
Some breaking changes are introduced here, most important ones are