Lua53 fixes #23
Open
Lua53 fixes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find lua executables with suffix. eg. fails to find something like 'lua53.exe'
This should be refactored so luacom module isn't dumped into global space but one step at a time.
Added compatibility code so luacom can still build under Lua 5.1
than matching against lua headers.
greatwolf
commented
Mar 8, 2020
| IF(LUA_EXECUTABLE) | ||
| EXECUTE_PROCESS(COMMAND ${LUA_EXECUTABLE} -v | ||
| OUTPUT_VARIABLE lua_version_str | ||
| ERROR_VARIABLE lua_version_str) |
There was a problem hiding this comment.
Just wanted to mention, for some reason Lua 5.1 seems to output the version string to stderr. At least that's the case for me under Win7. That's the reason for setting ERROR_VARIABLE to lua_version_str here, in case the interpreter splits out the version string to stderr, cmake will capture it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some various fixes particular to CMake detection so it can better find later versions of Lua as well as LuaJIT.
Also had to fix some of the lua C calls carryover from pre Lua 5.2, like
luaL_registerandlua_strlen. I knowLUA_COMPAT_MODULEcan be defined for backwards compatibility but it assumes that the lua runtime hasluaL_openlibcompiled in (luaL_registeris a#defineintoluaL_openlib. I ran into linking issues since my runtime didn't have it.It seems to make more sense to just make luacom use the latest Lua C api and put any compatibility code in LuaCompat.* to smooth out version differences. It helps reduce
#ifdeflitter into other source files.Last thing, added a rockspec file that uses cmake to build since it's already in the project.