Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream changes #18

Merged
merged 26 commits into from
Jan 31, 2023
Merged

Merge upstream changes #18

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
925341b
Update README.rst
russellballestrini Oct 14, 2019
71ad3d4
Update README.rst
russellballestrini Oct 14, 2019
638db47
Add link to AWS OSS Blog post
ejholmes Nov 15, 2019
1c07ff2
Merge pull request #747 from cloudtools/aws-blogpost
ejholmes Nov 18, 2019
7fc9648
Locked stacks still have requirements (#746)
mromaszewicz Nov 20, 2019
106ddf3
change diff to use CFN change sets instead of comparing template dict…
ITProKyle Feb 9, 2020
46bb7fe
Doc Update: Sturdy -> Onica (#739)
fbattistella Feb 17, 2020
471cc28
Add YAML environment file support (#740)
mromaszewicz Feb 17, 2020
b6d3118
Fix ami lookup 'Name' key error (#734)
Feb 17, 2020
9cf93c3
Fix jinja req and keypair tests
phobologic Feb 17, 2020
98a1cbf
fix diff functional tests
phobologic Feb 17, 2020
722ba88
Move template to an actual resource
phobologic Feb 17, 2020
44a98ef
Fix raw unit tests
phobologic Feb 17, 2020
c113f64
Fix new SNS based functional tests
phobologic Feb 17, 2020
5215e6a
Sleep for 20 seconds between tests to avoid rate limiting
phobologic Feb 17, 2020
13ec7a2
Twiddle with times to try and fix timeouts
phobologic Feb 18, 2020
9bbb391
Add the import-related stack statuses (#752)
laconc Feb 27, 2020
6221107
fix stack.set_outputs not being called by diff if stack did not chang…
ITProKyle Apr 21, 2020
0f8c233
Fix python 2.7/3.5 dependency issue
phobologic Apr 21, 2020
06a4bee
add cf notification arns (#756)
russellballestrini May 29, 2020
72eb1b0
specify dependency for boto3 in the correct way for multiple version …
TomRitserveldt Aug 22, 2020
4e32f25
Release 1.7.1 (#760)
phobologic Aug 22, 2020
eda3a52
address breaking moto change to awslambda (#763)
hauntingEcho Sep 14, 2020
c022c2f
Added Python version validation before update kms decrypt output (#765)
bmcoelho Oct 29, 2020
f563a6f
Release 1.7.2 (#767)
phobologic Nov 10, 2020
867a03f
Fix exception in 'stacker build --dump' when targets are defined
shawnsmith Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix stack.set_outputs not being called by diff if stack did not change ( 
cloudtools#754)

* fix stack.set_outputs not being called if stack did not change

resolves cloudtools#753

* set_outputs for locked stacks
  • Loading branch information
@ITProKyle
ITProKyle authored Apr 21, 2020
commit 6221107483fb4ff08e91856e824fd5e0e510988f
5 changes: 4 additions & 1 deletion stacker/actions/diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,12 @@ def _diff_stack(self, stack, **kwargs):
if not build.should_submit(stack):
return NotSubmittedStatus()

provider = self.build_provider(stack)

if not build.should_update(stack):
stack.set_outputs(provider.get_outputs(stack.fqn))
return NotUpdatedStatus()

provider = self.build_provider(stack)
tags = build.build_stack_tags(stack)

stack.resolve(self.context, provider)
Expand All @@ -179,6 +181,7 @@ def _diff_stack(self, stack, **kwargs):
stack.set_outputs(outputs)
except exceptions.StackDidNotChange:
logger.info('No changes: %s', stack.fqn)
stack.set_outputs(provider.get_outputs(stack.fqn))

return COMPLETE

Expand Down