Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask in episode 4 has no shadow #305

Open
K-Meech opened this issue Nov 10, 2023 · 1 comment
Open

Mask in episode 4 has no shadow #305

K-Meech opened this issue Nov 10, 2023 · 1 comment
Labels
status:wait Progress dependent on another issue or conversation type:template and tools Issue about template and tools

Comments

@K-Meech
Copy link
Contributor

K-Meech commented Nov 10, 2023

What is the problem?

The mask in episode 4 is shown with no shadow around it, even though it is specified with .image-with-shadow in the markdown

This makes it difficult to interpret as the white parts of the image blend directly into the lesson background:

Screenshot 2023-11-10 163430

Location of problem (optional)

No response
@tobyhodges
Copy link
Member

No equivalent to the image-with-shadow class has yet been implemented in varnish, the package that defines layout and styling in the new lesson infrastructure. I have been meaning to finish up a PR to address this, which I started but it turned out to be more complicated than I predicted.

@tobyhodges tobyhodges added status:wait Progress dependent on another issue or conversation type:template and tools Issue about template and tools labels Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:wait Progress dependent on another issue or conversation type:template and tools Issue about template and tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobyhodges @K-Meech