Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: undrop database statement #5701

Closed
dantengsky opened this issue May 31, 2022 · 1 comment · Fixed by #5770
Closed

Feature: undrop database statement #5701

dantengsky opened this issue May 31, 2022 · 1 comment · Fixed by #5770
Assignees
Labels
C-feature Category: feature community-take good first issue Category: good first issue

Comments

@dantengsky
Copy link
Member

dantengsky commented May 31, 2022

Summary

As schema api already supports undrop_database operation

https://github.com/datafuselabs/databend/blob/main/common/meta/api/src/schema_api_impl.rs#L268

undrop database statement can be implemented now.

  • the syntax:

UNDROP DATABASE <name>

  • the "sementics"
    undrop the dropped table ... : -), e.g.
  create database test;
  create table test.tbl (a int);
  drop database test;
  select * from test.tbl; -- expects error 1003, `UnknownDatabase`
  undrop database test;
  select * from test.tbl; -- back to normal

reference:

@dantengsky dantengsky added C-feature Category: feature community-take good first issue Category: good first issue labels May 31, 2022
@LiuYuHui
Copy link
Contributor

LiuYuHui commented Jun 1, 2022

/assignme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature community-take good first issue Category: good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants