Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_restarting_does_not_deadlock #8849

Merged
merged 5 commits into from
Oct 29, 2024
+69 −42
Merged

Fix test_restarting_does_not_deadlock #8849

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3048877
Make wait_until_worker_has_tasks event based
fjetter Aug 30, 2024
56622d8
replace nanny with worker
fjetter Aug 30, 2024
1639508
rewrite test
fjetter Sep 2, 2024
a009e71
Merge branch 'main' into shuffle_failures
fjetter Sep 2, 2024
5fc3d74
Merge branch 'main' into shuffle_failures
fjetter Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rewrite test
  • Loading branch information
@fjetter
fjetter committed Sep 2, 2024
commit 163950841f0f4d154d7cc99fff6a4e09700e379a
11 changes: 3 additions & 8 deletions distributed/shuffle/tests/test_shuffle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,18 +618,13 @@ async def test_restarting_does_not_deadlock(c, s):
)
df = await c.persist(df)
expected = await c.compute(df)

async with (
Worker(s.address) as b,
wait_until_worker_has_tasks(
"shuffle-transfer", b.worker_address, 1, s
) as event,
):
async with Worker(s.address) as b:
with dask.config.set({"dataframe.shuffle.method": "p2p"}):
out = df.shuffle("x")
assert not s.workers[b.worker_address].has_what
result = c.compute(out)
await event.wait()
while not s.extensions["shuffle"].active_shuffles:
await asyncio.sleep(0)
a.status = Status.paused
await async_poll_for(lambda: len(s.running) == 1, timeout=5)
b.batched_stream.close()
Expand Down
Loading