Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: several trivial refactorings for test_framework and dead code removing #6420

Merged
merged 4 commits into from
Nov 21, 2024
Merged

refactor: several trivial refactorings for test_framework and dead code removing #6420

merged 4 commits into from
Nov 21, 2024

Conversation

knst
Copy link
Collaborator

@knst knst commented Nov 21, 2024

What was done?

see each commit

How Has This Been Tested?

Run unit and functional tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

UdjinM6
UdjinM6 approved these changes Nov 21, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a34caec

@PastaPastaPasta PastaPastaPasta merged commit c79cffe into dashpay:develop Nov 21, 2024
11 of 20 checks passed
@UdjinM6 UdjinM6 added this to the 22.1 milestone Nov 21, 2024
@knst knst deleted the refactor-trivial branch November 26, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22.1
Development

Successfully merging this pull request may close these issues.
3 participants
@knst @UdjinM6 @PastaPastaPasta