Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add rpc help text for "ehf" field #5628

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix: add rpc help text for "ehf" field #5628

merged 1 commit into from
Oct 20, 2023

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Oct 20, 2023

Issue being fixed or feature implemented

#5597 follow-up

What was done?

add missing filed description

How Has This Been Tested?

help getblockchaininfo

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added the RPC Some notable changes to RPC params/behaviour/descriptions label Oct 20, 2023
@UdjinM6 UdjinM6 added this to the 20 milestone Oct 20, 2023
ogabrielides
ogabrielides approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

PastaPastaPasta
PastaPastaPasta approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit 5d8ffe5 into dashpay:develop Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@ogabrielides ogabrielides ogabrielides approved these changes

Assignees
No one assigned
Labels
RPC Some notable changes to RPC params/behaviour/descriptions
Projects
None yet
Milestone
20
Development

Successfully merging this pull request may close these issues.
3 participants
@UdjinM6 @ogabrielides @PastaPastaPasta