Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): skip more jobs in "FAST_MODE" #5311

Merged
merged 1 commit into from
Apr 14, 2023
Merged

fix(ci): skip more jobs in "FAST_MODE" #5311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(ci): skip more jobs in "FAST_MODE"
  • Loading branch information
@UdjinM6
UdjinM6 committed Apr 9, 2023
commit cc611ea85f6968bd02bd73a5a52a55980b276be1
16 changes: 12 additions & 4 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,21 +245,27 @@ linux64-build:
BUILD_TARGET: linux64

linux64_cxx20-build:
extends: .build-template
extends:
- .build-template
- .skip-in-fast-mode-template
needs:
- x86_64-pc-linux-gnu-debug
variables:
BUILD_TARGET: linux64_cxx20

linux64_sqlite-build:
extends: .build-template
extends:
- .build-template
- .skip-in-fast-mode-template
needs:
- x86_64-pc-linux-gnu-debug
variables:
BUILD_TARGET: linux64_sqlite

linux64_fuzz-build:
extends: .build-template
extends:
- .build-template
- .skip-in-fast-mode-template
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fuzz build is important for fast mode because usually it catches high percentage of all failures.

There is almost hundred of C++ source and any changes in class/structure interfaces, any noticeable big refactoring or big changes almost always cause a fail during fuzz build.

I vote for keeping linux64_fuzz-build in fast-mode

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... but we don't really run src/test/fuzz/fuzz anywhere as far as I can tell, we just compile it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just on this week PRs that failed for fuzz related code (compile, not run!):

needs:
- x86_64-pc-linux-gnu-debug
variables:
Expand Down Expand Up @@ -320,7 +326,9 @@ linux64-test:
BUILD_TARGET: linux64

linux64_sqlite-test:
extends: .test-template
extends:
- .test-template
- .skip-in-fast-mode-template
needs:
- linux64_sqlite-build
variables:
Expand Down