Overview

Continuing the work from #3939 to ensure that Tor support is available after the deprecation of Torv2 (source). More information about it is available at bitcoin#18884.

This PR attempts to implement bitcoin#19031 (which were split into various pull requests for ease of review) so that Torv3 support is available in Core.

Contents

The PR heavily relies upon functionality that wasn't been implemented then, requiring multiple dependencies. Therefore, those features have also been backported and logged accordingly.

Dependencies needed by bitcoin#19031

• Merge p2p: supplying and using asmap to improve IP bucketing in addrman bitcoin/bitcoin#16702 ("p2p: supplying and using asmap to improve IP bucketing in addrman" by naumenkogs)

• Merge config, net, test: asmap feature refinements and functional tests bitcoin/bitcoin#17812 ("config, net, test: asmap feature refinements and functional tests" by fanquake)

• Merge Support serialization of std::vector<bool> bitcoin/bitcoin#16730 ("Support serialization of std::vector" by sipa)

  • Segmented and available for review as merge #17812, #16702, #16730, #18023: supplying and using asmap to improve IP bucketing in addrman #4028

• Merge util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool bitcoin/bitcoin#13815 ("util: Add [[nodiscard]] to all {Decode,Parse}... functions returning bool" by practicalswift)

  • Segmented and available for review as partial merge #13815: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool #4035

• Partial merge Support output descriptors in scantxoutset bitcoin/bitcoin#13697 ("Support output descriptors in scantxoutset" by sipa)

• Mostly merge Add C++17 build to Travis bitcoin/bitcoin#18591 ("Add C++17 build to Travis" by sipa)

• Mostly merge span: update constructors to match c++20 draft spec and add lifetimebound attribute bitcoin/bitcoin#19387 ("span: update constructors to match c++20 draft spec and add lifetimebound attribute" by theuni)

  • Segmented and available for review as partial merge #13697, #18591, #19387, #18468: update constructors to match c++20 draft spec  #4036

• Mostly merge Serialization improvements step 5 (blockencodings) bitcoin/bitcoin#18112 ("Serialization improvements step 5 (blockencodings)" by sipa)

• Partial merge Serialization improvements step 4 (undo.h) bitcoin/bitcoin#18021 ("Serialization improvements step 4 (undo.h)" by sipa)

  • Segmented and available for review as merge #12752, #10785, #17896, #17957, #18021, #18112: serialization improvements  #4037

• Merge refactor: Make HexStr take a span bitcoin/bitcoin#19660 ("refactor: Make HexStr take a span" by laanwj)

• Merge refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o) bitcoin/bitcoin#19373 ("refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o)" by laanwj, using script documented by MarcoFalke)

• Merge Implement Keccak and SHA3_256 bitcoin/bitcoin#19841 ("Implement Keccak and SHA3_256" by laanwj)

  • Segmented and available for review as Merge #19660, #19373, #19841, #13862, #13866, #17280, #17682 and partial #19326, #14978: Auxiliary Backports #4164

• Merge refactor: make EncodeBase{32,64} consume Spans bitcoin/bitcoin#19687 ("refactor: make EncodeBase{32,64} consume Spans" by theStack)

  • Segmented and available for review as Merge #19628, #19687: change CNetAddr::ip to have flexible size #4166

As part of bitcoin#19031

• Complete the BIP155 implementation and upgrade to TORv3 bitcoin/bitcoin#19954 ("Complete the BIP155 implementation and upgrade to TORv3" by vasild)

• net: CNetAddr: add support to (un)serialize as ADDRv2 bitcoin/bitcoin#19845 ("net: CNetAddr: add support to (un)serialize as ADDRv2" by vasild)

  • Segmented and available for review as partial #8149 and merge #19845, #19954: Complete the BIP155 implementation and upgrade to TORv3 #4025 (this pull request)

• net: change CNetAddr::ip to have flexible size bitcoin/bitcoin#19628 ("net: change CNetAddr::ip to have flexible size" by vasild)

  • Segmented and available for review as Merge #19628, #19687: change CNetAddr::ip to have flexible size #4166

Disclosures

• This is a work in progress. Dash-specific changes have not been tested, only compilation and unit test success has been ensured. Running the client on a testnet is necessary.
• Tests fail. I do not know why, I do not know how. They fail. No, they don't :)
• I am not too familiar with serialization logic and it is possible that some of the code will break.

Changes that need review

• SerializationOp's handling of nServices in CAddress 28878d3#diff-8e2ffc8fe0e0847a6aac311a93b2faeebd2d76ddb2c81741bb8cf7448287807eR381