Collection of PRs and single commits missed in previous backports #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
617c96d [depends] Set OSX_MIN_VERSION to 10.8 (fanquake)
…ction 6dbfe08 [qa] test signrawtransaction merge with missing inputs (Matt Corallo) ec4f7e4 [qa] Add second input to signrawtransaction test case (Matt Corallo) 691710a [qa] Test that decoderawtransaction throws with extra data appended (Matt Corallo) 922bea9 Better handle invalid parameters to signrawtransaction (Matt Corallo) 7ea0ad5 Fail in DecodeHexTx if there is extra data at the end (Matt Corallo)
e6111b2 Make peer id logging consistent ("peer=%d" instead of "peer %d") (Matt Corallo)
6aadc75 Disconnect on mempool requests from peers when over the upload limit. (Gregory Maxwell)
codablock
force-pushed
the
pr_backport_bitcoin_0.14-12
branch
from
78e6ddf to
1086851
Compare
|
Hmm... |
|
Hmm yeah, I assumed it might be useful in the future but I checked Bitcoin 0.15 now and even there it is only used for RBF. Should I remove that commit? |
|
So I guess we are missing some other RBF-related changes then, right? We already have some RBF-related code in Dash, it's just disabled by default. Maybe it's better to backport these missing fixes too instead? |
|
The only RBF related PRs that I left out were related to RPC changes or which added new ways to enable RBF. We should be safe without these PRs. So what about IsAllFromMe? Remove it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few full PR backports and individual commits from PRs that I decided to not backport (e.g. RBF, or SegWit related).
I'll do another PR later for more individual commits that were part of compact block related PRs.
Sources of commits in this PR:
Full PR: bitcoin#9114
Part of bitcoin#8309: fa9976b
Full PR: bitcoin#9650
Parts bitcoin#8456: 766e8a4 and 52dde66
Full PR: bitcoin#9486
Full PR: bitcoin#7166