Skip to content

Commit

Permalink
test: Wait for recovered sig in rpc_verifyislock.py (#3975)
Browse files Browse the repository at this point in the history
Should fix failures like https://gitlab.com/dashpay/dash/-/jobs/997361410.

Looks like the reason for the failures is queuing recovered sigs here for processing https://github.com/dashpay/dash/blob/2493d851a74552db5739ee7916012af1715a1b43/src/llmq/quorums_instantsend.cpp#L876.
  • Loading branch information
xdustinface authored Feb 3, 2021
1 parent 2493d85 commit bbf8eac
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/functional/rpc_verifyislock.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from test_framework.messages import CTransaction, FromHex, hash256, ser_compact_size, ser_string
from test_framework.test_framework import DashTestFramework
from test_framework.util import assert_raises_rpc_error
from test_framework.util import assert_raises_rpc_error, wait_until

'''
rpc_verifyislock.py
Expand Down Expand Up @@ -38,7 +38,7 @@ def run_test(self):
request_id_buf += txin.prevout.serialize()
request_id = hash256(request_id_buf)[::-1].hex()

assert(node.quorum("hasrecsig", 100, request_id, txid))
wait_until(lambda: node.quorum("hasrecsig", 100, request_id, txid))

rec_sig = node.quorum("getrecsig", 100, request_id, txid)['sig']
assert(node.verifyislock(request_id, txid, rec_sig))
Expand Down

0 comments on commit bbf8eac

Please sign in to comment.