Skip processing in SyncTransaction when chain is not synced yet

Applies to CInstantSendManager and CChainLocksHandler. This fixes extremely high RAM usage on reindex and resync, which happens to many/all transactions being kept track of non-locked TXs (nonLockedTxs) and TXs per block (blockTxs).
dashpay · May 13, 2019 · a471bd6 · a471bd6
1 parent 56f3119
commit a471bd6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/llmq/quorums_chainlocks.cpp b/src/llmq/quorums_chainlocks.cpp
@@ -347,6 +347,10 @@ void CChainLocksHandler::TrySignChainTip()
 
 void CChainLocksHandler::SyncTransaction(const CTransaction& tx, const CBlockIndex* pindex, int posInBlock)
 {
+    if (!masternodeSync.IsBlockchainSynced()) {
+        return;
+    }
+
     bool handleTx = true;
     if (tx.IsCoinBase() || tx.vin.empty()) {
         handleTx = false;

diff --git a/src/llmq/quorums_instantsend.cpp b/src/llmq/quorums_instantsend.cpp
@@ -964,6 +964,10 @@ void CInstantSendManager::SyncTransaction(const CTransaction& tx, const CBlockIn
         }
     }
 
+    if (!masternodeSync.IsBlockchainSynced()) {
+        return;
+    }
+
     bool chainlocked = pindex && chainLocksHandler->HasChainLock(pindex->nHeight, pindex->GetBlockHash());
     if (islockHash.IsNull() && !chainlocked) {
         ProcessTx(tx, Params().GetConsensus());