Skip to content

Commit

Permalink
Merge #6404: fix(qt): avoid potential precision loss in amounts on Go…
Browse files Browse the repository at this point in the history
…vernance Tab

c48efda fix(qt): avoid potential precision loss in amounts on Governance Tab (UdjinM6)

Pull request description:

  ## Issue being fixed or feature implemented
  #6403 (comment)

  ## What was done?

  ## How Has This Been Tested?

  ## Breaking Changes

  ## Checklist:
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  knst:
    utACK c48efda
  PastaPastaPasta:
    utACK c48efda

Tree-SHA512: 705bc154e10150e32e3ff04d4a90de14e29ffd195cc9f94a753dd1b4588f2730d6526cd66d851005b956e0d074d39250d142baa946bea8df95dbc92718931762
  • Loading branch information
PastaPastaPasta committed Nov 21, 2024
2 parents 8a14482 + c48efda commit 242dc51
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/qt/governancelist.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ QDateTime Proposal::startDate() const { return m_startDate; }

QDateTime Proposal::endDate() const { return m_endDate; }

float Proposal::paymentAmount() const { return m_paymentAmount; }
double Proposal::paymentAmount() const { return m_paymentAmount; }

QString Proposal::url() const { return m_url; }

Expand Down
4 changes: 2 additions & 2 deletions src/qt/governancelist.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class Proposal : public QObject
QString m_title;
QDateTime m_startDate;
QDateTime m_endDate;
float m_paymentAmount;
double m_paymentAmount;
QString m_url;

public:
Expand All @@ -76,7 +76,7 @@ class Proposal : public QObject
QString hash() const;
QDateTime startDate() const;
QDateTime endDate() const;
float paymentAmount() const;
double paymentAmount() const;
QString url() const;
bool isActive() const;
QString votingStatus(int nAbsVoteReq) const;
Expand Down

0 comments on commit 242dc51

Please sign in to comment.