feat(extension): add warning before enable unknown source extension

daoos · May 12, 2022 · 91403c2 · 91403c2
1 parent 9c095b4
commit 91403c2
Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/src/renderer/components/ExtensionManager.vue b/src/renderer/components/ExtensionManager.vue
@@ -400,6 +400,17 @@ async function fetchContent (type: 'readme' | 'changelog', extension: Extension)
   }
 }
 
+async function checkOrigin (extension: Extension) {
+  if (extension.origin === 'unknown') {
+    if (!(await useModal().confirm({
+      content: t('extension.unknown-origin-tips'),
+      okText: t('extension.enable'),
+    }))) {
+      throw new Error('canceled')
+    }
+  }
+}
+
 async function checkRequirements (extension: Extension) {
   if (extension.requirements.premium && !getPurchased()) {
     useToast().show('info', t('premium.need-purchase', extension.displayName))
@@ -483,6 +494,7 @@ async function enable (extension?: Extension) {
     return
   }
 
+  await checkOrigin(extension)
   await checkRequirements(extension)
 
   logger.debug('enable', extension.id)

diff --git a/src/share/i18n/languages/en.ts b/src/share/i18n/languages/en.ts
@@ -556,6 +556,7 @@ const data = {
     'registry': 'Registry',
     'activation-time': 'Activation Time',
     'requirement': 'Requirement',
+    'unknown-origin-tips': 'Using extensions from unknown sources can be risky, still want to enable?',
   },
 }
 

diff --git a/src/share/i18n/languages/zh-CN.ts b/src/share/i18n/languages/zh-CN.ts
@@ -557,6 +557,7 @@ const data: BaseLanguage = {
     'registry': '仓库源',
     'activation-time': '激活时间',
     'requirement': '需要',
+    'unknown-origin-tips': '使用未知来源的扩展可能有风险，仍然要启用吗？'
   },
 }