Skip to content

Commit

Permalink
Upload benchmark results to S3 when the check step failed (awslabs#998)
Browse files Browse the repository at this point in the history 
* Save benchmark results to S3 when the check step failed

Signed-off-by: Vladislav Volodkin <vladvolodkin@gmail.com>

* Update all job defenitions

Signed-off-by: Vladislav Volodkin <vladvolodkin@gmail.com>

---------

Signed-off-by: Vladislav Volodkin <vladvolodkin@gmail.com>
  • Loading branch information
@vladem
vladem authored Sep 6, 2024
1 parent 1db78f3 commit 813f95d
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 40 deletions.
48 changes: 24 additions & 24 deletions .github/workflows/bench.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ jobs:
run: cargo build --release
- name: Run Benchmark
run: mountpoint-s3/scripts/fs_bench.sh
- name: Save benchmark results in S3
if: inputs.s3_bench_results_prefix
run: .github/actions/scripts/save-benchmark-results.sh
env:
S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
COMMIT_ID: ${{ inputs.ref }}
- name: Check benchmark results
uses: benchmark-action/github-action-benchmark@v1
with:
Expand All @@ -70,14 +78,6 @@ jobs:
auto-push: ${{ inputs.publish }}
comment-on-alert: true
max-items-in-chart: 20
- name: Save benchmark results in S3
if: inputs.s3_bench_results_prefix
run: .github/actions/scripts/save-benchmark-results.sh
env:
S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
COMMIT_ID: ${{ inputs.ref }}

latency-bench:
name: Benchmark (Latency)
Expand Down Expand Up @@ -110,6 +110,14 @@ jobs:
run: cargo build --release
- name: Run Benchmark
run: mountpoint-s3/scripts/fs_latency_bench.sh
- name: Save benchmark results in S3
if: inputs.s3_bench_results_prefix
run: .github/actions/scripts/save-benchmark-results.sh
env:
S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
COMMIT_ID: ${{ inputs.ref }}
- name: Check benchmark results
uses: benchmark-action/github-action-benchmark@v1
with:
Expand All @@ -124,14 +132,6 @@ jobs:
auto-push: ${{ inputs.publish }}
comment-on-alert: true
max-items-in-chart: 20
- name: Save benchmark results in S3
if: inputs.s3_bench_results_prefix
run: .github/actions/scripts/save-benchmark-results.sh
env:
S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
COMMIT_ID: ${{ inputs.ref }}

cache-bench:
name: Benchmark (Cache)
Expand Down Expand Up @@ -166,6 +166,14 @@ jobs:
env:
S3_MOUNT_LOCAL_STORAGE: yes
run: mountpoint-s3/scripts/fs_cache_bench.sh
- name: Save benchmark results in S3
if: inputs.s3_bench_results_prefix
run: .github/actions/scripts/save-benchmark-results.sh
env:
S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
COMMIT_ID: ${{ inputs.ref }}
- name: Check benchmark results
uses: benchmark-action/github-action-benchmark@v1
with:
Expand All @@ -180,11 +188,3 @@ jobs:
auto-push: ${{ inputs.publish }}
comment-on-alert: true
max-items-in-chart: 20
- name: Save benchmark results in S3
if: inputs.s3_bench_results_prefix
run: .github/actions/scripts/save-benchmark-results.sh
env:
S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
COMMIT_ID: ${{ inputs.ref }}
32 changes: 16 additions & 16 deletions .github/workflows/bench_s3express.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ jobs:
run: cargo build --release
- name: Run Benchmark
run: mountpoint-s3/scripts/fs_bench.sh
- name: Save benchmark results in S3
if: inputs.s3_bench_results_prefix
run: .github/actions/scripts/save-benchmark-results.sh
env:
S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
COMMIT_ID: ${{ inputs.ref }}
- name: Check benchmark results
uses: benchmark-action/github-action-benchmark@v1
with:
Expand All @@ -71,14 +79,6 @@ jobs:
auto-push: ${{ inputs.publish }}
comment-on-alert: true
max-items-in-chart: 20
- name: Save benchmark results in S3
if: inputs.s3_bench_results_prefix
run: .github/actions/scripts/save-benchmark-results.sh
env:
S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
COMMIT_ID: ${{ inputs.ref }}

latency-bench:
name: Benchmark (Latency)
Expand Down Expand Up @@ -111,6 +111,14 @@ jobs:
run: cargo build --release
- name: Run Benchmark
run: mountpoint-s3/scripts/fs_latency_bench.sh
- name: Save benchmark results in S3
if: inputs.s3_bench_results_prefix
run: .github/actions/scripts/save-benchmark-results.sh
env:
S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
COMMIT_ID: ${{ inputs.ref }}
- name: Check benchmark results
uses: benchmark-action/github-action-benchmark@v1
with:
Expand All @@ -125,11 +133,3 @@ jobs:
auto-push: ${{ inputs.publish }}
comment-on-alert: true
max-items-in-chart: 20
- name: Save benchmark results in S3
if: inputs.s3_bench_results_prefix
run: .github/actions/scripts/save-benchmark-results.sh
env:
S3_BENCH_REGION: ${{ vars.S3_BENCH_REGION }}
S3_BENCH_BUCKET_NAME: ${{ vars.S3_BENCH_RESULTS_BUCKET_NAME }}
S3_BENCH_RESULTS_PREFIX: ${{ inputs.s3_bench_results_prefix }}/${{ github.job }}
COMMIT_ID: ${{ inputs.ref }}

0 comments on commit 813f95d

Please sign in to comment.