Selection views update properly when selections are merged

dannguyen · Jun 14, 2012 · 470f469 · 470f469
1 parent 47533ad
commit 470f469
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/spec/app/editor-spec.coffee b/spec/app/editor-spec.coffee
@@ -768,8 +768,19 @@ describe "Editor", ->
         expect(selectionView.regions.length).toBe 3
         expect(selectionView.find('.selection').length).toBe 3
 
+    describe "when a selection merges with another selection", ->
+      it "removes the merged selection view", ->
+        editSession = editor.activeEditSession
+        editSession.setCursorScreenPosition([4, 10])
+        editSession.selectToScreenPosition([5, 27])
+        editSession.addCursorAtScreenPosition([3, 10])
+        editSession.selectToScreenPosition([6, 27])
+
+        expect(editor.getSelectionViews().length).toBe 1
+        expect(editor.find('.selection').length).toBe 3
+
   describe "cursor rendering", ->
-    
+
 
     describe "when the cursor moves", ->
       charWidth = null

diff --git a/src/app/selection-view.coffee b/src/app/selection-view.coffee
@@ -13,7 +13,7 @@ class SelectionView extends View
   initialize: ({@editor, @selection} = {}) ->
     @regions = []
     @selection.on 'change-screen-range', => @updateAppearance()
-    @selection.on 'destroy', => @remove('ignore')
+    @selection.on 'destroy', => @remove()
     @updateAppearance()
 
   updateAppearance: ->