fix crash in checkclass from unknown template valueType (#3129)

danmar · Feb 13, 2021 · 75e439e · 75e439e
1 parent 1eafed9
commit 75e439e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -74,7 +74,9 @@ static const char * getFunctionTypeName(Function::Type type)
 
 static bool isVariableCopyNeeded(const Variable &var)
 {
-    return var.isPointer() || (var.type() && var.type()->needInitialization == Type::NeedInitialization::True) || (var.valueType()->type >= ValueType::Type::CHAR);
+    return var.isPointer() ||
+           (var.type() && var.type()->needInitialization == Type::NeedInitialization::True) ||
+           (var.valueType() && var.valueType()->type >= ValueType::Type::CHAR);
 }
 
 //---------------------------------------------------------------------------

diff --git a/test/testconstructors.cpp b/test/testconstructors.cpp
@@ -196,6 +196,8 @@ class TestConstructors : public TestFixture {
         TEST_CASE(uninitComparisonAssignment);    // ticket #7429
 
         TEST_CASE(uninitTemplate1); // ticket #7372
+
+        TEST_CASE(unknownTemplateType);
     }
 
 
@@ -3903,6 +3905,18 @@ class TestConstructors : public TestFixture {
               "A<B<T1, T2>>::A() : m_value(false) {}\n");
         ASSERT_EQUALS("", errout.str());
     }
+
+    void unknownTemplateType() {
+        check("template <typename T> class A {\n"
+              "private:\n"
+              "    T m;\n"
+              "public:\n"
+              "    A& operator=() { return *this; }\n"
+              "};\n"
+              "A<decltype(SOMETHING)> a;");
+        ASSERT_EQUALS("", errout.str());
+    }
+
 };
 
 REGISTER_TEST(TestConstructors)