Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create BANA CSS Draft.css #295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create BANA CSS Draft.css #295

wants to merge 1 commit into from

Conversation

wfree-aph
Copy link
Collaborator

Adds BANA CSS Draft to Experiments > CSS Examples. Please let me know what you think.

Adds BANA CSS Draft to Experiments > CSS Examples. Please let me know what you think.
@wfree-aph wfree-aph requested a review from bertfrees December 6, 2024 20:21
padding: 0;
line-height: 1rem; /* To avoid excessive rounding, the reading system will need to handle the space between lines */
font-family: 'SimBraille', monospace; /* Unicode braille font */
white-space: pre; /* Preserve braille spacing and indentation */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The white-space: pre is strange to have as default. What made you do that?



/* Level 1: No Nesting (1-3) */
.level-1 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is related to #162 (Lists and Nested lists, calculating indents), but I don't know which markup this CSS relies on.

  • It doesn't seem to match any of the 4 options given in that issue.
  • We're currently not recommending any special markup for nested lists in the best practices (and I don't think we need to: I have given an example here for styling a multi-level list).

text-indent: 4rem; /* Runovers align to cell 5 */
}

.exercise.level-2 .subitem {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What markup does this rely on? I can't find anything in the best practices.

}

/* Stanza Breaks */
.poetry .stanza {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What markup does his rely on? We mention the poetry class for lists, but we don't mention stanza and stanza-number.

content: '⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶⠶';
}

p {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was already a rule for p (above).

}

/* Directions and Instructions */
.instructions {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the "instructions" class for? I can't make much sense out of this rule (especially the font-style).

padding-left: 0; /* First line of main entry at cell 1 */
text-indent: 4rem; /* Runovers stay at cell 5 */
}
.poetry.level-2 .sublevel-1 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What markup does this rely on? I'm seeing yet another pattern here than for lists and exercises.


/* Cell-5 Heading (h2) */
h2 {
margin-left: 4rem; /* Indented to the fifth cell */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left and right margins must be specified in ch. (There are several cases like this one.)

}

/* Transcriber's Note */
.transcriber-note {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for the div or span kind of transcriber note?

.transcriber-note::after {
content: "⠈⠨⠜"; /* Ending symbol */
position: absolute; /* Inline with the text */
right: 0; /* Ensures the symbol appears at the end of the last line */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this will do what you intended. What exactly do you want to accomplish? Can you make an example that we can put in the styling best practices?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants