Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump node and finally fix pnpm :amaze: #3871

Merged
merged 17 commits into from
Dec 5, 2024
Merged

chore: bump node and finally fix pnpm :amaze: #3871

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2ce7100
chore: bump node and finally fix pnpm :amaze:
rebelchris Nov 22, 2024
8c8119b
fix: force lock
rebelchris Nov 22, 2024
899ce4e
fix: bump cache
rebelchris Nov 22, 2024
5c0c613
fix: bump cache
rebelchris Nov 22, 2024
924946f
fix: lintin/ts
rebelchris Nov 22, 2024
c3ef3f8
fix: lint
rebelchris Nov 22, 2024
a793669
Merge branch 'main' into chore-bumps
rebelchris Nov 22, 2024
5a7e7b9
Merge branch 'main' of https://github.com/dailydotdev/apps into chore…
ilasw Nov 26, 2024
4a6849e
Merge branch 'main' into chore-bumps
rebelchris Dec 4, 2024
de3f754
fix: update pnpm version lock
rebelchris Dec 4, 2024
1b15f61
fix: shotcut build
rebelchris Dec 4, 2024
e9a0635
fix: test cases
rebelchris Dec 4, 2024
ae72997
fix: test cases
rebelchris Dec 4, 2024
42448cf
Merge branch 'main' into chore-bumps
rebelchris Dec 4, 2024
fa30dcf
fix: should wait for nock to finish
rebelchris Dec 4, 2024
02e12c2
Merge branch 'main' into chore-bumps
rebelchris Dec 5, 2024
09c3514
Merge branch 'main' into chore-bumps
rebelchris Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: lintin/ts
  • Loading branch information
@rebelchris
rebelchris committed Nov 22, 2024
commit 924946f445c0ab236145b7a4f2ad8d71f39d4c72
3 changes: 3 additions & 0 deletions packages/extension/src/newtab/ShortcutLinks/ShortcutLinks.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ const defaultSettings: RemoteSettings = {
};

const defaultBootData: BootCacheData = {
exp: undefined,
geo: {},
postData: undefined,
alerts: defaultAlerts,
user: { ...defaultUser, createdAt: '2024-02-16T00:00:00.000Z' },
settings: defaultSettings,
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/components/LazyImage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ function LazyImageComponent(
loading={eager ? 'eager' : 'lazy'}
src={src}
onError={onError}
// @ts-expect-error - Not supported by react yet
/* @ts-expect-error - Not supported by react yet */ /* eslint-disable react/no-unknown-property */
fetchpriority={fetchPriority}
/>
{children}
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/components/Logo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const LogoSvgElem = ({
return (
<img
loading="eager"
// @ts-expect-error - Not supported by react yet
/* @ts-expect-error - Not supported by react yet */ /* eslint-disable react/no-unknown-property */
fetchpriority="high"
src={src}
className={className?.container}
Expand Down
1 change: 0 additions & 1 deletion packages/webapp/pages/onboarding.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ export function OnboardPage(): ReactElement {
<img
alt="Onboarding background"
className="pointer-events-none absolute inset-0 -z-1 h-full w-full object-cover tablet:object-center"
/* eslint-disable react/no-unknown-property */
fetchPriority="high"
loading="eager"
role="presentation"
Expand Down