fix: migrating to pnpm workspaces (#1876)

Migrate lerna to pnpm workspaces
dailydotdev · Jun 19, 2023 · 20e79fd · 20e79fd
1 parent e747d28
commit 20e79fd
Show file tree

Hide file tree

Showing 77 changed files with 14,317 additions and 118,170 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -1,37 +1,23 @@
 version: 2.1
 
-commands:
-  create_concatenated_package_lock:
-    description: Concatenate all package-lock.json files recognized by lerna.js into single file. File is used as checksum source for part of caching key.
-    parameters:
-      filename:
-        type: string
-    steps:
-      - run:
-          name: Combine package-lock.json files to single file
-          command: lerna la -a | awk -F packages '{printf "\"packages%s/package-lock.json\" ", $2}' | xargs cat > << parameters.filename >>
-
 jobs:
   build:
     docker:
       - image: cimg/node:18.16.0
     steps:
       - checkout
       - run:
-          name: Install lerna
-          command: npm i --prefix=$HOME/.local -g lerna@6
-      - create_concatenated_package_lock:
-          filename: combined-package-lock.txt
+          name: Install pnpm
+          command: npm i --prefix=$HOME/.local -g pnpm
       - restore_cache:
           keys:
-            - deps-v5-{{ .Branch }}-{{ checksum "combined-package-lock.txt" }}
             - deps-v5-{{ .Branch }}
             - deps-v5-
       - run:
           name: Install dependencies
-          command: lerna bootstrap
+          command: pnpm install
       - save_cache:
-          key: deps-v5-{{ .Branch }}-{{ checksum "combined-package-lock.txt" }}
+          key: deps-v5-{{ .Branch }}
           paths:
             - ./node_modules
             - ./packages/eslint-config/node_modules
@@ -50,20 +36,17 @@ jobs:
     steps:
       - checkout
       - run:
-          name: Install lerna
-          command: npm i --prefix=$HOME/.local -g lerna@6
-      - create_concatenated_package_lock:
-          filename: combined-package-lock.txt
+          name: Install pnpm
+          command: npm i --prefix=$HOME/.local -g pnpm
       - restore_cache:
           keys:
-            - deps-v5-{{ .Branch }}-{{ checksum "combined-package-lock.txt" }}
             - deps-v5-{{ .Branch }}
             - deps-v5-
       - run:
           name: Install dependencies
-          command: lerna bootstrap
+          command: pnpm install
       - save_cache:
-          key: deps-v5-{{ .Branch }}-{{ checksum "combined-package-lock.txt" }}
+          key: deps-v5-{{ .Branch }}
           paths:
             - ./node_modules
             - ./packages/eslint-config/node_modules
@@ -74,7 +57,7 @@ jobs:
             - ./packages/extension/node_modules
       - run:
           name: Test
-          command: lerna run test:ci
+          command: pnpm run -r test:ci
           environment:
             JEST_JUNIT_OUTPUT_DIR: ../../test-results
       - store_test_results:

diff --git a/.gitpod.yml b/.gitpod.yml
@@ -38,8 +38,8 @@ tasks:
       nvm install
       nvm use
     init: |
-      npm i -g lerna@6
-      lerna bootstrap
+      npm i -g pnpm
+      pnpm install
     command: |
       cd packages/webapp
       npm run dev
diff --git a/.pnpmfile.cjs b/.pnpmfile.cjs
@@ -0,0 +1,19 @@
+function switchToPreact(pkg, dep) {
+  if (pkg.dependencies[dep]) {
+    pkg.dependencies[dep] = 'npm:@preact/compat@17.0.2';
+  }
+}
+
+function readPackage(pkg) {
+  if (pkg.dependencies) {
+    switchToPreact(pkg, 'react');
+    switchToPreact(pkg, 'react-dom');
+  }
+  return pkg
+}
+
+module.exports = {
+  hooks: {
+    readPackage
+  }
+}
diff --git a/Dockerfile b/Dockerfile
@@ -5,7 +5,6 @@ RUN mkdir -p /opt/app
 WORKDIR /opt/app
 
 COPY package*.json .
-COPY lerna.json .
 
 COPY packages/eslint-config/package*.json ./packages/eslint-config/
 
@@ -23,8 +22,8 @@ RUN \
   apk --no-cache add \
   libc6-compat
 
-RUN npm i -g lerna
-RUN lerna bootstrap
+RUN npm i -g pnpm
+RUN pnpm install
 
 COPY packages ./packages
 

diff --git a/README.md b/README.md
@@ -26,9 +26,8 @@ The decision was made to allow faster iterations and to keep features parity in
 
 ## Technology
 
-* NPM for managing dependencies.
 * Node v18.16.0 (a `.nvmrc` is presented for [nvm](https://github.com/nvm-sh/nvm) users).
-* [lerna](https://github.com/lerna/lerna) for managing the monorepo.
+* [pnpm](https://pnpm.io/workspaces) for managing the monorepo and dependencies.
 
 ## Projects
 
@@ -70,15 +69,15 @@ https://github.com/dailydotdev/.github/blob/master/CONTRIBUTING.md
 
 After cloning the project, please make sure to run the following commands to bootstrap the project:
 ```
-npm i -g lerna
-lerna bootstrap
+npm i -g pnpm
+pnpm install
 ```
 
 ## Firefox Review
 
 * Install node v18.16.0 and npm v9.5.1
-* Install `lerna` as a global package `npm i -g lerna` 
-* Bootstrap project `lerna bootstrap`
+* Install `pnpm` as a global package `npm i -g pnpm` 
+* Bootstrap project `pnpm install`
 * Change working directory to extension project `cd packages/extension`
 * Build Firefox version `npm run build:firefox`
 * Firefox build should be located at `dist`
diff --git a/lerna.json b/lerna.json
diff --git a/package-lock.json b/package-lock.json