Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create monorepo e2e spec #1079

Merged
merged 11 commits into from
Jan 6, 2025
Merged

chore: create monorepo e2e spec #1079

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ffe0478
chore: create monorepo e2e spec
rmarscher Dec 18, 2024
7412111
Add monorepo packageDir param to startApp e2e util
rmarscher Jan 5, 2025
b13053a
Merge remote-tracking branch 'origin/main' into chore/monorepo-spec
rmarscher Jan 5, 2025
503be50
Prettier
rmarscher Jan 5, 2025
63d1e33
eslint ignore import error
rmarscher Jan 5, 2025
3bc75dc
Fix tests
rmarscher Jan 5, 2025
358f71d
Incorporate #1101
rmarscher Jan 5, 2025
b8863c0
Prettier
rmarscher Jan 5, 2025
3593a4e
Add packageManager to monorepo test name
rmarscher Jan 5, 2025
f9efa60
Use join instead of string concat
rmarscher Jan 6, 2025
91db8bb
Delete e2e/fixtures/monorepo/packages/waku-project/.gitignore
dai-shi Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Incorporate #1101
  • Loading branch information
@rmarscher
rmarscher committed Jan 5, 2025
commit 358f71dcee6c86ff5752ee2f0a306da5e4dccb0e
28 changes: 15 additions & 13 deletions e2e/monorepo.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,21 @@ import { test, prepareStandaloneSetup } from './utils.js';
const startApp = prepareStandaloneSetup('monorepo');

for (const mode of ['DEV', 'PRD'] as const) {
test.describe(`monorepo: ${mode}`, () => {
let port: number;
let stopApp: () => Promise<void>;
test.beforeAll(async () => {
({ port, stopApp } = await startApp(mode, 'packages/waku-project'));
});
test.afterAll(async () => {
await stopApp();
});
for (const packageManager of ['npm', 'pnpm', 'yarn'] as const) {
test.describe(`monorepo: ${mode}`, () => {
let port: number;
let stopApp: () => Promise<void>;
test.beforeAll(async () => {
({ port, stopApp } = await startApp(mode, packageManager, 'packages/waku-project'));
});
test.afterAll(async () => {
await stopApp();
});

test('renders the home page', async ({ page }) => {
await page.goto(`http://localhost:${port}`);
await expect(page.getByTestId('header')).toHaveText('Waku');
test('renders the home page', async ({ page }) => {
await page.goto(`http://localhost:${port}`);
await expect(page.getByTestId('header')).toHaveText('Waku');
});
});
});
}
}
11 changes: 10 additions & 1 deletion e2e/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,12 @@ export const prepareNormalSetup = (fixtureName: string) => {
return startApp;
};

const PACKAGE_INSTALL = {
npm: (path: string) => `npm add ${path}`,
pnpm: (path: string) => `pnpm add ${path}`,
yarn: (path: string) => `yarn add ${path}`,
} as const;

export const prepareStandaloneSetup = (fixtureName: string) => {
const wakuDir = fileURLToPath(new URL('../packages/waku', import.meta.url));
const { version } = createRequire(import.meta.url)(
Expand All @@ -151,7 +157,7 @@ export const prepareStandaloneSetup = (fixtureName: string) => {
const tmpDir = process.env.TEMP_DIR || tmpdir();
let standaloneDir: string | undefined;
let built = false;
const startApp = async (mode: 'DEV' | 'PRD' | 'STATIC', packageDir = '') => {
const startApp = async (mode: 'DEV' | 'PRD' | 'STATIC', packageManager: 'npm' | 'pnpm' | 'yarn' = 'npm', packageDir = '') => {
if (!standaloneDir) {
standaloneDir = mkdtempSync(join(tmpDir, fixtureName));
cpSync(fixtureDir, standaloneDir, {
Expand All @@ -164,6 +170,9 @@ export const prepareStandaloneSetup = (fixtureName: string) => {
cwd: wakuDir,
stdio: 'inherit',
});
const wakuPackageTgz = join(standaloneDir, `waku-${version}.tgz`);
const installScript = PACKAGE_INSTALL[packageManager](wakuPackageTgz);
execSync(installScript, { cwd: standaloneDir, stdio: 'inherit' });
execSync(
`npm install --force ${join(standaloneDir, `waku-${version}.tgz`)}`,
{ cwd: standaloneDir, stdio: 'inherit' },
Expand Down
Loading