Merge pull request #29 from l0b0/fix/Sequence

fix: Correct reference to `Sequence`
dabeaz-course · Jul 25, 2023 · 09c35c1 · 09c35c1
2 parents 393db77 + c079eb9
commit 09c35c1
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/Exercises/ex2_5.md b/Exercises/ex2_5.md
@@ -175,7 +175,7 @@ function.
 
 import collections
 ...
-class RideData(collections.Sequence):
+class RideData(collections.abc.Sequence):
     def __init__(self):
         self.routes = []      # Columns
         self.dates = []
@@ -204,7 +204,7 @@ into 4 separate `append()` operations.
 # readrides.py
 ...
 
-class RideData(collections.Sequence):
+class RideData(collections.abc.Sequence):
     def __init__(self):
         # Each value is a list with all of the values (a column)
         self.routes = []

diff --git a/Exercises/soln2_5.md b/Exercises/soln2_5.md
@@ -93,7 +93,7 @@ def read_rides_as_columns(filename):
 # The great "fake"
 
 import collections
-class RideData(collections.Sequence):
+class RideData(collections.abc.Sequence):
     def __init__(self):
         # Each value is a list with all of the values (a column)
         self.routes = []

diff --git a/Solutions/2_5/readrides.py b/Solutions/2_5/readrides.py
@@ -88,7 +88,7 @@ def read_rides_as_columns(filename):
 # The great "fake"
 
 import collections
-class RideData(collections.Sequence):
+class RideData(collections.abc.Sequence):
     def __init__(self):
         # Each value is a list with all of the values (a column)
         self.routes = []

diff --git a/Solutions/2_6/colreader.py b/Solutions/2_6/colreader.py
@@ -3,7 +3,7 @@
 import collections
 import csv
 
-class DataCollection(collections.Sequence):
+class DataCollection(collections.abc.Sequence):
     def __init__(self, columns):
         self.column_names = list(columns)
         self.column_data = list(columns.values())
@@ -34,4 +34,3 @@ def read_csv_as_columns(filename, types):
     tracemalloc.start()
     data = read_csv_as_columns('../../Data/ctabus.csv', [intern, intern, intern, int])
     print(tracemalloc.get_traced_memory())
-