Decouple MATLAB Functions Test from Controller.def
#6752
+63
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a breakoff of #6740 containing just the changes to the MATLAB sources test. It updates the test to search for functions in the exposed header files rather than relying on the
Controller.def
file. This means that it can catch new functions whether or not the contributor remembers to place them in the def file.The previous test also excluded constants from its search. I see no reason to do this, so I removed that restriction. I've created and attached a diff of the functions the test searches for before and after this change. Viewing it reveals that, with the exception of the aforementioned constants, there is no difference between the functions checked by the two versions.
Keep in mind that in order to achieve this, I had to update the function exclusion list. I think that all of these exclusions make sense (and I've added comments to that effect). The two exceptions are
wbu_system_tmpdir
andwbu_system_webots_instance_path
. My guess is that these should be included in the MATLAB API and were just never added toController.def
, but if there's another reason these should be excluded, let me know. IMO, adding them is out of scope for this PR and should be addressed separately.The
supervisor.h
changes are to remove thewb_supervisor_field_remove_mf_item
reference, which is a non-existent function that the grep search was picking up.matlab_functions_diff.txt (GitHub won't let me upload a
.diff
)