Fix: Cannot read properties of undefined (reading 'startPoints') #8966
+12
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Related: #8859
One of the possible reasons to the issue is
Cannot read properties of undefined (reading 'startPoints')
error. For some unknown reasonhandler
object inside of svg js event becomes undefined making an error in dragend hander. This leads to not dispatchingcanvas.dragend
event so new object state coords are not saved. When the error occurs, object is visually moved but if we change frame and go back the annotation will be on the previous place.In this fix, we will use
shape
as source of start point coordinatesHow has this been tested?
Checklist
develop
branch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changesLicense
Feel free to contact the maintainers if that's a concern.