Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cannot read properties of undefined (reading 'startPoints') #8966

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Jan 20, 2025

Motivation and context

Related: #8859
One of the possible reasons to the issue is Cannot read properties of undefined (reading 'startPoints') error. For some unknown reason handler object inside of svg js event becomes undefined making an error in dragend hander. This leads to not dispatching canvas.dragend event so new object state coords are not saved. When the error occurs, object is visually moved but if we change frame and go back the annotation will be on the previous place.

annotaion-jump

In this fix, we will use shape as source of start point coordinates

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov added the ui/ux label Jan 20, 2025
@klakhov klakhov requested a review from bsekachev as a code owner January 20, 2025 10:31
Copy link
Member

@bsekachev bsekachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsekachev
Copy link
Member

Just please add changelog entry

@klakhov klakhov requested a review from nmanovic as a code owner January 20, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants