Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid inheritance in tests #8962

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix invalid inheritance in tests #8962

merged 1 commit into from
Jan 20, 2025

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Jan 17, 2025 •
edited
Loading

Motivation and context

  • Fixed invalid test inheritance in task tests, which led to extra ~10-15 minutes of testing

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zhiltsov-max
Copy link
Contributor Author

cc @archibald1418

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.83%. Comparing base (8613254) to head (16a1570).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8962      +/-   ##
===========================================
- Coverage    73.88%   73.83%   -0.06%     
===========================================
  Files          416      417       +1     
  Lines        44421    44583     +162     
  Branches      3996     4028      +32     
===========================================
+ Hits         32820    32917      +97     
- Misses       11601    11666      +65
Components Coverage Δ
cvat-ui 78.27% <77.15%> (-0.15%) ⬇️
cvat-server 70.06% <ø> (ø)

@zhiltsov-max zhiltsov-max requested review from archibald1418 and removed request for azhavoro January 20, 2025 11:06
@archibald1418 archibald1418 merged commit d3be5b6 into develop Jan 20, 2025
34 checks passed
@archibald1418 archibald1418 deleted the zm/fix-test-inheritance branch January 20, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archibald1418 archibald1418 archibald1418 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiltsov-max @codecov-commenter @archibald1418