Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test for missing frames after exporting a CVAT dataset #8827

Merged
merged 12 commits into from
Dec 19, 2024
+77 −2
Merged

Regression test for missing frames after exporting a CVAT dataset #8827

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1862551
Regression test for missing frames after exporting a CVAT dataset
Dec 13, 2024
7dfe012
linted changes with Black
Dec 13, 2024
31963ef
add fixtures for reseting db and cache per function
Dec 16, 2024
0d3e477
linted code
Dec 16, 2024
87312a4
add params image/video, start_frame + fixture for an image/video task
Dec 17, 2024
7756d4e
linted code, removed match statement
Dec 17, 2024
54572a7
Merge branch 'develop' into ov/regression_export_cvat_dataset
Dec 17, 2024
338d52a
linted code with latest black version (vscode black turned old)
Dec 17, 2024
8b22b94
Merge branch 'develop' into ov/regression_export_cvat_dataset
Dec 18, 2024
e41da1a
move yield inside ctx to work with the same client later
archibald1418 Dec 18, 2024
d9f0d5f
factor out end_frame calculations to utils
Dec 19, 2024
4998837
sort imports
Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linted code, removed match statement
  • Loading branch information
Oleg Valiulin committed Dec 17, 2024
commit 7756d4e5d785f7161ec0db388eccd87acc00f5fa
48 changes: 23 additions & 25 deletions tests/python/rest_api/test_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,6 @@ def test_datumaro_export_without_annotations_includes_image_info(
assert tuple(related_image["size"]) > (0, 0)



@pytest.mark.usefixtures("restore_db_per_function")
@pytest.mark.usefixtures("restore_cvat_data_per_function")
@pytest.mark.usefixtures("restore_redis_ondisk_per_function")
Expand Down Expand Up @@ -6359,7 +6358,7 @@ def check_element_outside_count(track_idx, element_idx, expected_count):
@pytest.mark.usefixtures("restore_redis_inmem_per_function")
class TestPatchExportFrames(TestTaskData):

@fixture(scope='class')
@fixture(scope="class")
@parametrize("media_type", [_SourceDataType.images, _SourceDataType.video])
@parametrize("step", [5])
@parametrize("frame_count", [20])
Expand All @@ -6372,33 +6371,22 @@ def fxt_uploaded_media_task(
frame_count: int,
start_frame: Optional[int],
) -> Generator[tuple[_TaskSpec, Task, str], None, None]:
args = dict(
request=request,
frame_count=frame_count,
step=step,
start_frame=start_frame
)
args = dict(request=request, frame_count=frame_count, step=step, start_frame=start_frame)

match media_type:
case _SourceDataType.images:
(spec, task_id) = next(self._uploaded_images_task_fxt_base(**args))
case _SourceDataType.video:
(spec, task_id) = next(self._uploaded_video_task_fxt_base(**args))
if media_type == _SourceDataType.images:
(spec, task_id) = next(self._uploaded_images_task_fxt_base(**args))
else:
(spec, task_id) = next(self._uploaded_video_task_fxt_base(**args))

with make_sdk_client(self._USERNAME) as client:
task = client.tasks.retrieve(task_id)

yield (spec, task, f"CVAT for {media_type} 1.1")
archibald1418 marked this conversation as resolved.
Show resolved Hide resolved


@pytest.mark.usefixtures("restore_redis_ondisk_per_function")
@parametrize("spec, task, format_name", [fixture_ref(fxt_uploaded_media_task)])
def test_export_with_non_default_frame_step(
self,
tmp_path: Path,
spec: _TaskSpec,
task: Task,
format_name: str
self, tmp_path: Path, spec: _TaskSpec, task: Task, format_name: str
):

dataset_file = tmp_path / "dataset.zip"
Expand All @@ -6412,12 +6400,22 @@ def get_img_index(zinfo: zipfile.ZipInfo) -> int:

# get frames and sort them
with zipfile.ZipFile(dataset_file) as dataset:
frames = np.array([png_idx for png_idx in map(get_img_index, dataset.filelist) if png_idx != -1])
frames = np.array(
[png_idx for png_idx in map(get_img_index, dataset.filelist) if png_idx != -1]
)
frames.sort()

task_meta = task.get_meta()
(src_start_frame, src_stop_frame, src_frame_step) = task_meta['start_frame'], task_meta['stop_frame'], spec.frame_step
src_end_frame = src_stop_frame - ((src_stop_frame - src_start_frame) % src_frame_step) + src_frame_step

assert len(frames) == spec.size == task_meta['size'], "Some frames were lost"
assert np.all(frames == np.arange(src_start_frame, src_end_frame, src_frame_step)), "Some frames are wrong"
(src_start_frame, src_stop_frame, src_frame_step) = (
task_meta["start_frame"],
task_meta["stop_frame"],
spec.frame_step,
)
src_end_frame = (
src_stop_frame - ((src_stop_frame - src_start_frame) % src_frame_step) + src_frame_step
) # taken from TestTaskData._compute_annotation_segment_params

assert len(frames) == spec.size == task_meta["size"], "Some frames were lost"
assert np.all(
frames == np.arange(src_start_frame, src_end_frame, src_frame_step)
), "Some frames are wrong"
Loading