Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the feature to Remove annotation objects in a specified range of frames #3617

Merged
merged 26 commits into from
Oct 26, 2021
Merged

Added the feature to Remove annotation objects in a specified range of frames #3617

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
25527db
Test Commit for Remove Range
gudipudiramanakumar Aug 27, 2021
aab67f4
Remove annotations in range merged with remove annotations button merged
gudipudiramanakumar Aug 28, 2021
a085554
Update annotation-reducer.ts
gudipudiramanakumar Aug 28, 2021
7839fe8
Update annotation-actions.ts
gudipudiramanakumar Aug 28, 2021
c092a56
Update annotation-reducer.ts
gudipudiramanakumar Aug 28, 2021
4d39b94
Merge branch 'openvinotoolkit:develop' into feature-removeannotations…
gudipudiramanakumar Sep 4, 2021
cde900f
Converting remove range component to hook based component
gudipudiramanakumar Oct 12, 2021
5ed81c3
Improved clear in cvat core and implemented remove range
gudipudiramanakumar Oct 18, 2021
6f5b922
Merge branch 'feature-removeannotationsinrange' into develop
gudipudiramanakumar Oct 18, 2021
d47db3c
Merge pull request #1 from gudipudiramanakumar/develop
gudipudiramanakumar Oct 18, 2021
25bbb49
Matching only the needed parts
gudipudiramanakumar Oct 18, 2021
6dba4e8
Merge branch 'feature-removeannotationsinrange' of https://github.com…
gudipudiramanakumar Oct 18, 2021
d72833d
Delete out.json
gudipudiramanakumar Oct 18, 2021
abca64f
Update annotations-collection.js
gudipudiramanakumar Oct 18, 2021
fb30089
Added a checkbox to remove range modal
gudipudiramanakumar Oct 19, 2021
2e714f1
ESLint fixed
gudipudiramanakumar Oct 20, 2021
88d1ec1
Merge branch 'openvinotoolkit:develop' into feature-removeannotations…
gudipudiramanakumar Oct 20, 2021
6cc2403
More ESLint and other updates
gudipudiramanakumar Oct 20, 2021
5317c04
Merge branch 'feature-removeannotationsinrange' of https://github.com…
gudipudiramanakumar Oct 20, 2021
c7a4a03
Update annotation-menu.tsx
gudipudiramanakumar Oct 20, 2021
e5c23b0
Update remove-range-confirm.tsx
gudipudiramanakumar Oct 21, 2021
455466f
Changed the approach of removeAnnotations modal
gudipudiramanakumar Oct 23, 2021
a313f46
Merge branch 'openvinotoolkit:develop' into feature-removeannotations…
gudipudiramanakumar Oct 25, 2021
8b0dc67
Added to changelog
gudipudiramanakumar Oct 26, 2021
96e73a7
Merge branch 'feature-removeannotationsinrange' of https://github.com…
gudipudiramanakumar Oct 26, 2021
b92b93c
Merge branch 'openvinotoolkit:develop' into feature-removeannotations…
gudipudiramanakumar Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update annotations-collection.js
  • Loading branch information
@gudipudiramanakumar
gudipudiramanakumar committed Oct 18, 2021
commit abca64f8350eff397bc06990aab77c3cdf112d4b
6 changes: 1 addition & 5 deletions cvat-core/src/annotations-collection.js
View file
Original file line number Diff line number Diff line change
@@ -570,7 +570,7 @@
if(track.frame<=endframe){
if(deltrack_keyframes_only){
for(let keyframe in track.shapes){
if (keyframe <= endframe)
if (keyframe>=startframe && keyframe <= endframe)
delete track.shapes[keyframe];
}
}
@@ -586,14 +586,10 @@


objects_removable.forEach((object)=>{
console.log(object.clientID);
console.log(object);
delete this.objects[object.clientID];
});

this.count = this.count - objects_removable.length;
console.log("Count");
console.log(this.count);

this.flush = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe if remove from range, this flag should not be set to true.
If this flag is true, client sends put annotation request and all annotations are removed from the database.
If this flag is false, client sends only changes.

return;