Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsed actions: Fill out rest of grammar #2440

Open
2 tasks
pokey opened this issue Jun 19, 2024 · 0 comments
Open
2 tasks

parsed actions: Fill out rest of grammar #2440

pokey opened this issue Jun 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@pokey
Copy link
Member

pokey commented Jun 19, 2024

We currently only support a subset of our command grammar for our custom parsed actions. We would like to:

  • Set up our test harness to try running all spoken forms from our recorded tests through our custom command parser to check that the output payload matches the command payload
  • Expand the parsed command grammar so that we pass all of the above tests

Note that we need to think about whether we want to support all spoken forms. The following examples seem awkward:

  • Decorated marks, eg "take air". In this case, using the spoken forms for characters seems a bit strange. In a written grammar, it seems more natural to do something like "take a"
  • Ordinals / numbers, eg "take second token". Might be fine for smaller ones, but it's a bit strange for larger ordinals / numbers to spell them out
  • Plurals, eg "take two tokens"

Keep in mind also the following relevant issues to our parser:

@pokey pokey added the enhancement New feature or request label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant