Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect common installation mistakes and show error message #1953

Open
2 of 5 tasks
pokey opened this issue Oct 16, 2023 · 1 comment · May be fixed by #2720
Open
2 of 5 tasks

Detect common installation mistakes and show error message #1953

pokey opened this issue Oct 16, 2023 · 1 comment · May be fixed by #2720
Assignees
@AndreasArvidsson
Labels
enhancement New feature or request talon Related to cursorless-talon
Milestone
1.0

Comments

@pokey
Copy link
Member

pokey commented Oct 16, 2023 •
edited by AndreasArvidsson
Loading

  • User forgets to clone community => Look for action we depend on and show error message during init if not detected
  • User clones monorepo instead of cursorless-talon => Have python file at root of mono-repo that shows error message
  • user hasn't installed talon?
  • user hasn't installed cursorless-talon (note that we can look for .cursorless directory, tho old installations won't have it)
  • user missing command-server

Note that if they just want cursorless keyboard, they don't need any of these things, so figure out how to handle

See #1951 for an example where a user tried to use cursorless without Talon community repo
@pokey pokey added the enhancement New feature or request label Oct 16, 2023
@pokey pokey mentioned this issue Oct 16, 2023
Closed
@AndreasArvidsson
Copy link
Member

Sounds good

@auscompgeek auscompgeek added the talon Related to cursorless-talon label Oct 19, 2023
@pokey pokey mentioned this issue May 30, 2024
Open
@pokey pokey added this to the 1.0 milestone May 30, 2024
This was referenced Nov 21, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 1, 2024
@AndreasArvidsson @pokey @pre-commit-ci-lite
Added Talon notification if the user has cloned the monorepo (#2690)
6c86092 
Related ##1953

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@AndreasArvidsson @pokey
Check for community installation (#2692)
b65ac4e 
Related ##1953

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
cursorless-bot pushed a commit to cursorless-dev/cursorless-talon that referenced this issue Dec 12, 2024
@AndreasArvidsson @pokey @cursorless-bot
Check for community installation (#2692)
6196f17 
Related #cursorless-dev/cursorless#1953

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
cursorless-bot pushed a commit that referenced this issue Dec 12, 2024
@AndreasArvidsson @pokey
Check for community installation (#2692)
1cdf5a3 
Related ##1953

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [/] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
@AndreasArvidsson AndreasArvidsson self-assigned this Jan 11, 2025
@AndreasArvidsson AndreasArvidsson linked a pull request Jan 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreasArvidsson AndreasArvidsson

Labels
enhancement New feature or request talon Related to cursorless-talon
Projects
A bit of polish
Status: To do
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Show webview about missing installation dependencies cursorless-dev/cursorless
3 participants
@auscompgeek @pokey @AndreasArvidsson