Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes for components and implement counter_fsm attribute #453

Merged
merged 13 commits into from
Sep 4, 2024
Merged

Add attributes for components and implement counter_fsm attribute #453

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f4d6af5
add attributes to frontend
UnsignedByte Aug 27, 2024
9c9c529
add invalid test
UnsignedByte Aug 27, 2024
c5f7f25
add attributes to IR
UnsignedByte Aug 28, 2024
ad63e95
move fsm type decision to a pass
UnsignedByte Aug 28, 2024
5def849
add pass to main pass set
UnsignedByte Aug 28, 2024
1d11248
add better error message
UnsignedByte Aug 29, 2024
7f1373d
fix syntax for multiple attributes
UnsignedByte Aug 29, 2024
ddb1eb0
disable fsm attrs for externals
UnsignedByte Aug 29, 2024
08aac8d
restructure attributes to work with
UnsignedByte Aug 29, 2024
ff65552
transfer attribute changes
UnsignedByte Sep 4, 2024
0c0825a
remove unused attributes and replace with dummy
UnsignedByte Sep 4, 2024
1e55bc5
re-add doc comments
UnsignedByte Sep 4, 2024
ccb0bb1
small doc prettying
UnsignedByte Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
disable fsm attrs for externals
  • Loading branch information
@UnsignedByte
UnsignedByte committed Sep 4, 2024
commit ddb1eb05efc0b3bfd21e3325cac4d6ad71c15132
5 changes: 5 additions & 0 deletions crates/filament/src/ir_passes/fsm_attributes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ impl Visitor for FSMAttributes {
return;
}

// If the component is external or generated, do not add any slow FSM attributes
if data.comp.is_ext() || data.comp.is_gen() {
return;
}

// Get the delay of the component if it is a single event component
if data.comp.events().len() == 1 {
let delay = &data.comp.events().iter().next().unwrap().1.delay;
Expand Down