Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile error seen with GCC-14.1.1 and Clang-17.0.6 #22

Closed
wants to merge 1 commit into from
Closed

Fix compile error seen with GCC-14.1.1 and Clang-17.0.6 #22

wants to merge 1 commit into from

Conversation

UffeJakobsen
Copy link 

/tmp/dtl/Diff.hpp: In member function 'void dtl::Diff<elem, sequence, comparator>::enableTrivial() const':
/tmp/dtl/Diff.hpp:168:27: error: assignment of member 'trivial' in read-only object
  168 |             this->trivial = true;
      |             ~~~~~~~~~~~~~~^~~~~~

@UffeJakobsen
Fix compile error seen with GCC-14.1.1 and Clang-17.0.6
4f07e06 
```
/tmp/dtl/Diff.hpp: In member function 'void dtl::Diff<elem, sequence, comparator>::enableTrivial() const':
/tmp/dtl/Diff.hpp:168:27: error: assignment of member 'trivial' in read-only object
  168 |             this->trivial = true;
      |             ~~~~~~~~~~~~~~^~~~~~
```
@UffeJakobsen UffeJakobsen force-pushed the master_uj_compile_fix branch from 20094e0 to 4f07e06 Compare June 1, 2024 00:22
@AJenbo
Copy link

AJenbo commented Jul 6, 2024

Duplicate of #18

@xaizek xaizek mentioned this pull request Jul 11, 2024
Closed
@cubicdaiya
Copy link
Owner

Thank you for sending your PR. Since There is already the similar PR(#18), I merged it.

@cubicdaiya cubicdaiya closed this Jul 11, 2024
@UffeJakobsen UffeJakobsen deleted the master_uj_compile_fix branch July 29, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UffeJakobsen @AJenbo @cubicdaiya