Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Commit

Permalink
[Android] Remove xwalk_download_resource_throttle.*
Browse files Browse the repository at this point in the history
`XWalkDownloadResourceThrottle` has not been used since 2013 when commit
54f602a ("Refine some public files in xwalk runtime") removed all
callers.

Having these files around is a problem with the upcoming M53, as
https://codereview.chromium.org/2014803002/ removed
`content::DownloadControllerAndroid` and the code fails to link in debug
mode.
  • Loading branch information
Raphael Kubo da Costa committed Oct 6, 2016
1 parent de880ef commit 3b05347
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 86 deletions.
2 changes: 0 additions & 2 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,6 @@ source_set("xwalk_runtime") {
"runtime/browser/android/xwalk_cookie_access_policy.h",
"runtime/browser/android/xwalk_dev_tools_server.cc",
"runtime/browser/android/xwalk_dev_tools_server.h",
"runtime/browser/android/xwalk_download_resource_throttle.cc",
"runtime/browser/android/xwalk_download_resource_throttle.h",
"runtime/browser/android/xwalk_http_auth_handler.cc",
"runtime/browser/android/xwalk_http_auth_handler.h",
"runtime/browser/android/xwalk_http_auth_handler_base.cc",
Expand Down
39 changes: 0 additions & 39 deletions runtime/browser/android/xwalk_download_resource_throttle.cc

This file was deleted.

42 changes: 0 additions & 42 deletions runtime/browser/android/xwalk_download_resource_throttle.h

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include "net/url_request/url_request.h"
#include "xwalk/runtime/browser/android/net/url_constants.h"
#include "xwalk/runtime/browser/android/xwalk_contents_io_thread_client.h"
#include "xwalk/runtime/browser/android/xwalk_download_resource_throttle.h"
#include "xwalk/runtime/browser/android/xwalk_login_delegate.h"
#include "xwalk/runtime/browser/xwalk_content_browser_client.h"
#include "xwalk/runtime/common/xwalk_content_client.h"
Expand Down
2 changes: 0 additions & 2 deletions xwalk.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,6 @@
'runtime/browser/android/xwalk_cookie_access_policy.h',
'runtime/browser/android/xwalk_dev_tools_server.cc',
'runtime/browser/android/xwalk_dev_tools_server.h',
'runtime/browser/android/xwalk_download_resource_throttle.cc',
'runtime/browser/android/xwalk_download_resource_throttle.h',
'runtime/browser/android/xwalk_http_auth_handler.cc',
'runtime/browser/android/xwalk_http_auth_handler.h',
'runtime/browser/android/xwalk_http_auth_handler_base.cc',
Expand Down

0 comments on commit 3b05347

Please sign in to comment.