Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: only start one resource store routine on network cleanup in r… #6547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

server: only start one resource store routine on network cleanup in r… #6547

wants to merge 1 commit into from

Conversation

haircommander
Copy link
Member

…estore

to reduce the amount of CPU usage of many routines spinning and waiting for the CNI plugin to become ready

Signed-off-by: Peter Hunt~ pehunt@redhat.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 18, 2023
@openshift-ci openshift-ci bot requested review from klihub and wgahnagl January 18, 2023 21:17
@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 18, 2023
@haircommander haircommander force-pushed the cni-cleanup-one-routine branch 7 times, most recently from 5e679cb to c88ffab Compare January 20, 2023 18:22
@codecov
Copy link

codecov bot commented Jan 20, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 49.34%. Comparing base (6ab8bca) to head (1a6268f).
Report is 1242 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6547      +/-   ##
==========================================
+ Coverage   49.32%   49.34%   +0.01%     
==========================================
  Files         138      138              
  Lines       15774    15778       +4     
==========================================
+ Hits         7780     7785       +5     
+ Misses       7057     7055       -2     
- Partials      937      938       +1

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 9, 2023
@haircommander haircommander force-pushed the cni-cleanup-one-routine branch from c88ffab to 45e8faf Compare May 17, 2023 15:14
@haircommander
Copy link
Member Author

/retest

@sohankunkerkar sohankunkerkar removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2023
@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 19, 2023
@haircommander
Copy link
Member Author

/retest

@cri-o/cri-o-maintainers PTAL

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2023
@haircommander
server: only start one resource store routine on network cleanup in r…
1a6268f 
…estore

to reduce the amount of CPU usage of many routines spinning and waiting for the CNI plugin to become ready

Signed-off-by: Peter Hunt~ <pehunt@redhat.com>
@haircommander haircommander force-pushed the cni-cleanup-one-routine branch from 45e8faf to 1a6268f Compare October 24, 2023 20:09
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@saschagrunert
Copy link
Member

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 13, 2023
@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 12, 2024
@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 13, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 15, 2024
@haircommander haircommander mentioned this pull request Jun 3, 2024
Merged
@github-actions GitHub Actions
Copy link

Closing this PR since it had no activity in the past 90 days.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 15, 2024
@github-actions github-actions bot closed this Jul 15, 2024
@kwilczynski kwilczynski removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 15, 2024
@kwilczynski kwilczynski reopened this Jul 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 15, 2024

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-rhel-integration c88ffab link true /test ci-rhel-integration
ci/prow/ci-fedora-kata 1a6268f link true /test ci-fedora-kata
ci/prow/ci-e2e-conmonrs 1a6268f link true /test ci-e2e-conmonrs
ci/prow/ci-rhel-critest 1a6268f link true /test ci-rhel-critest
ci/prow/ci-crun-e2e 1a6268f link true /test ci-crun-e2e
ci/prow/ci-cgroupv2-e2e-features 1a6268f link true /test ci-cgroupv2-e2e-features
ci/prow/ci-e2e-evented-pleg 1a6268f link true /test ci-e2e-evented-pleg
ci/prow/ci-cgroupv2-integration 1a6268f link true /test ci-cgroupv2-integration
ci/prow/ci-fedora-critest 1a6268f link true /test ci-fedora-critest
ci/prow/ci-fedora-integration 1a6268f link true /test ci-fedora-integration
ci/prow/ci-cgroupv2-e2e-crun 1a6268f link true /test ci-cgroupv2-e2e-crun
ci/prow/ci-cgroupv2-e2e 1a6268f link true /test ci-cgroupv2-e2e
ci/prow/ci-e2e 1a6268f link true /test ci-e2e
ci/prow/ci-rhel-e2e 1a6268f link true /test ci-rhel-e2e
ci/prow/e2e-aws-ovn 1a6268f link true /test e2e-aws-ovn
ci/prow/ci-images 1a6268f link true /test ci-images
ci/prow/e2e-gcp-ovn 1a6268f link true /test e2e-gcp-ovn
ci/prow/images 1a6268f link true /test images
ci/prow/periodics-images 1a6268f link true /test periodics-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2024
@kwilczynski kwilczynski removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 2, 2024
@kwilczynski kwilczynski removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@haircommander @saschagrunert @openshift-merge-robot @kwilczynski @sohankunkerkar